343170 - Message tags shown twice in message header

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Please refer to bug 342708#13 comment #13 - #21

Comment 1

[Brett Leber]

On my machine/build (Windows XP, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629 Thunderbird/2.0a1 ID:2006062906), the tags are not duplicated in the message list pane, but in the message preview pane, they appear twice in the header under "Tags:". Note that I only observe this for 'original' labels (eg, Important, Personal), and not for tags created with the New Tag UI.

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #1)
Note that I only observe this
> for 'original' labels (eg, Important, Personal), and not for tags created with
> the New Tag UI.

I can confirm this.

We should limit this bug to this problem.

I'll file a new bug for the other problem with the combination of different Thunderbird and profile languages.

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

After switching to an other folder und switching back to the original folder, the tag is only shown once.

Comment 4

[Scott MacGregor]

Attachment: the fix

Don't add the label to the list of tag keys if it is already listed in the keywords string from the msg hdr.

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

Patch seems to be working.

Comment 6

[Brett Leber]

Works for me. Great work guys!

Comment 7

[Brett Leber]

I think I spoke too soon. I applied two tags--one default (eg Important) and one custom--and noted the correct tags in both the column and message header. After navigating off of the message and back to it, the header only shows the *default* label--the custom one is gone--but both are correctly listed in the Tag column.

Comment 8

[Brett Leber]

(In reply to comment #7)
> I think I spoke too soon. I applied two tags--one default (eg Important) and
> one custom--and noted the correct tags in both the column and message header.
> After navigating off of the message and back to it, the header only shows the
> *default* label--the custom one is gone--but both are correctly listed in the
> Tag column.

Let me revise this: tags created before this patch, while still available in my profile, don't show up in the message header after navigating off of the message and returning to it. (They still appear in the Tag column.) This is obviously not a big deal for me as a tester, but I thought it was worth noting that the tag itself is no good. Newer tags seem to stick fine in both the header and the column.