343184 - DnD month view: Drag and Drop of new All Day event opens Edit Event dialog

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Fall out from Bug 324271:
DnD month view: Drag and Drop of new All Day event opens Edit Event dialog

Steps to Reproduce:
1. Switch to month view
2. Create All Day event that lasts one day
3. Drag and Drop to another day

Actual Results:
Edit Event dialog for that event is displayed. Event is not moved to target day. Event is not shown until you refresh the view.

JavaScript Console shows:
    Warning: anonymous function does not always return a value
    Source File: chrome://calendar/content/calendar-month-view.xml 
    Line: 126, Column: 12

Additional Information:
If you restart Sunbird and drag and drop the existing event you will get the same results (not moved, not shown) but no Edit Event dialog.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060629 Sunbird/0.3a2+ (my own trunk build)

Comment 1

[Joey Minta]

Attachment: remove silly conditions

Patch removes silly extra conditions in the controllers.

Comment 2

[Joey Minta]

Comment on attachment 227701 [details] [diff] [review]
remove silly conditions

r=dmose

Comment 3

[Joey Minta]

A merged patch has been checked in.  (where "merged" means I checked in the same kinds of changes to calendar-views.js)

Comment 4

[Stefan Sitter [:ssitter]]

Works fine with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060721 Calendar/0.3a2+ and Lightning/0.1+ (2006-07-21-07, mozilla1.8) 
--> VERIFIED