Closed Bug 343207 Opened 18 years ago Closed 18 years ago

Sunbird is missing updater.ini

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

References

Details

Attachments

(1 file, 1 obsolete file)

Enables packaging of updater.ini
1.15 KB, patch
dmosedale
: first-review+
Details | Diff | Splinter Review 
Currently we're getting errors when packaging because of a missing updater.ini file. 

We have MOZ_UPDATER enabled.
Attached patch adds updater.ini (obsolete) — — Splinter Review 

        Attachment #227643 -
        Flags: first-review?(jminta)

    
    

    
  
(In reply to comment #0)
> We have MOZ_UPDATER enabled.
> 
I think the bigger question is: Why do we have this enabled?  See 308631.


    
    

    
  
Comment on attachment 227643 [details] [diff] [review]
adds updater.ini

There are a lot of prereqs before I'm ready to review this.

        Attachment #227643 -
        Flags: first-review?(jminta)

    
  
Status: NEW → ASSIGNED

    
  
Blocks: 341971

    
  

        Attachment #227643 -
        Attachment is obsolete: true

    
    

    
  
-> FIXED by patch in bug 341971
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
I can't find updater.ini in win32 build. From a quick look I see that the section that handles updater.ini is commented out in [http://lxr.mozilla.org/mozilla/source/calendar/locales/Makefile.in#217]. Reopen?

    
    

    
  
-> REOPENED

Good catch Stefan.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  

        Attachment #247879 -
        Flags: first-review?(dmose)

    
    

    
  
Comment on attachment 247879 [details] [diff] [review]
Enables packaging of updater.ini

r=dmose@mozilla.org

        Attachment #247879 -
        Flags: first-review?(dmose) → first-review+

    
    

    
  
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 247879 [details] [diff] [review]
Enables packaging of updater.ini


> #ifdef MOZ_UPDATER
>-#libs:: $(addprefix $(LOCALE_SRCDIR)/,updater/updater.ini)
>-#ifeq ($(OS_ARCH),WINNT)
>-#	iconv -f UTF-8 -t $(WIN_INSTALLER_CHARSET) $< > $(FINAL_TARGET)/updater.ini
>-#else
>-#ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
>-#	$(INSTALL) $^ $(FINAL_TARGET)/updater.app/Contents/MacOS
>-#else
>-#	$(INSTALL) $^ $(FINAL_TARGET)
>+libs:: $(addprefix $(LOCALE_SRCDIR)/,updater/updater.ini)
>+ifeq ($(OS_ARCH),WINNT)
>+	iconv -f UTF-8 -t $(WIN_INSTALLER_CHARSET) $< > $(FINAL_TARGET)/updater.ini
>+else
>+ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
>+	$(INSTALL) $^ $(FINAL_TARGET)/updater.app/Contents/MacOS
>+else
>+	$(INSTALL) $^ $(FINAL_TARGET)
> #endif
> #endif
> #endif

I think the '#' must be removed on the '#ifdef MOZ_UPDATER' and '#endif' lines too.

    
    

    
  
True.
Fix checked in.

    
    

    
  
VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: