[Mac] Improve appearance of HTML form controls

RESOLVED INVALID

Status

()

RESOLVED INVALID
12 years ago
11 years ago

People

(Reporter: kevin, Assigned: jaas)

Tracking

1.8 Branch
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

35.79 KB, image/jpeg
Details
3.56 KB, application/zip
Details
(Reporter)

Description

12 years ago
Mac OS X HTML form controls have a primitive appearance. Here is a patch to pretty them up. I've described the widget styles here: http://kmgerich.com/2006/03/11/mac-like-form-controls-for-firefox/

Josh asked me to file a separate bug for this.

References:

Bug 175279 : Use nsITheme with HTML form controls on Mac OS X (native-style form controls)
Bug 187150 : text box bottom and right sides are faint / invisible
(Reporter)

Comment 1

12 years ago
Created attachment 227650 [details]
Patch + two background images

The zip file contains a diff against the 1.8 branch and two images that should go in the layout/style directory.
(Reporter)

Updated

12 years ago
Attachment #227650 - Attachment is patch: false
Attachment #227650 - Attachment mime type: text/plain → application/zip
(Assignee)

Comment 2

12 years ago
+	select-background.png \
+	select-endcap-background.png \

We should only do that if we're building for Mac OS X, do a test after the initial assignment to _FILES and append the items if we're on Mac OS X.
(Assignee)

Comment 3

12 years ago
Created attachment 228166 [details]
popup closeup 1

In this closeup, you can see a dark black line bordering the right and bottom sides of the popup frame. Is that supposed to be there? If it is, it seems like it is one pixel too far to the right and thus sticking out from the side of the frame.
(Reporter)

Comment 4

12 years ago
Created attachment 228246 [details]
Patch #2 + images

Added more authentic styles for text areas, removed border on select popup, and toned down the gradient a bit on the select widget.
Attachment #227650 - Attachment is obsolete: true
(Assignee)

Comment 5

12 years ago
Patch #2 looks much better.

I was playing around with styling widgets and I noticed that with these patches we use the same buttons (input, radio buttons, and check boxes) as we do in Cocoa widgets, as a result of the change to nsNativeThemeMac. This is a problem because those buttons have a lot of problems that are not acceptable for an official version of Firefox (though Camino has been shipping them for a while, but to a smaller audience). One major problem is that they draw their focus rings outside of their frame quite often, leaving blue paint behind. There are others, this isn't the place to get into the list of problems.

I guess my point is that in order to accept this change, we are going to need to do some more cleanup. Perhaps we should put together a tracking bug for Cocoa form widget polish issues, if one doesn't exist already. Even if that is done, I don't find it very likely that we'll finish things in time. We'll see though.
(Reporter)

Comment 6

12 years ago
Yeah I'm aware of the focus ring painting problem. Is it possible to identify the biggest issues and sort them out in time for FF2? Is there anything I can do?

I also have a set of widget styles that doesn't change nsNativeThemeMac and looks a bit less native: http://kmgerich.com/2005/01/23/pretty-widgets-part-3/

I don't have this in patch form yet and I haven't looked at the code for over a year, but I could probably resurrect it, if there's still time. What do you think Josh?

Comment 7

12 years ago
(In reply to comment #5)

I'm not aware of any tracking bug per se.
Bug 298111 comes close.
Perhaps it is time to open one and collect all those widgets problems, as they apply to CocoaFox as well. And quite a few of those problems are relatively easy to solve by some tweaks in forms.css.

(Assignee)

Comment 8

12 years ago
> I also have a set of widget styles that doesn't change nsNativeThemeMac and
> looks a bit less native: http://kmgerich.com/2005/01/23/pretty-widgets-part-3/
> 
> I don't have this in patch form yet and I haven't looked at the code for over a
> year, but I could probably resurrect it, if there's still time. What do you
> think Josh?

I think if you could put together a patch that would be awesome. Those widgets still look a lot better than what we have. I'll also pursue the possibility of fixing some of the widget appearance bugs that plague cocoa widgets. Thanks!
Is this still relevant, now that bug 175279 (native-looking form controls) is fixed?
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.