Closed Bug 343278 Opened 18 years ago Closed 18 years ago

Hitting delete in the password manager doesn't delete the password

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta1

People

(Reporter: ttolonen, Assigned: ispiked)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

fix
999 bytes, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060630 Firefox/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060630 Firefox/3.0a1

Error: DeleteSignonSelected is not defined
Source File: chrome://passwordmgr/content/passwordManager.js
Line: 199

Reproducible: Always

Steps to Reproduce:
1. Open password manager
2. Hit delete key on keyboard
3. Check Error Console
Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060630 Minefield/3.0a1 ID:2006063004 [cairo] with same error in JS console
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch fix — — Splinter Review 
Assignee: nobody → ispiked
Status: NEW → ASSIGNED

        Attachment #227799 -
        Flags: review?(mconnor)

        Attachment #227799 -
        Flags: approval1.8.1?

    
  
Severity: normal → minor
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta1
Version: unspecified → 2.0 Branch

    
    

    
  
Comment on attachment 227799 [details] [diff] [review]
fix

man, this dates to v1.1 of this file... scary, but no risk

        Attachment #227799 -
        Flags: review?(mconnor)

        Attachment #227799 -
        Flags: review+

        Attachment #227799 -
        Flags: approval1.8.1?

        Attachment #227799 -
        Flags: approval1.8.1+

    
  
Whiteboard: [checkin needed]

    
    

    
  
mozilla/toolkit/components/passwordmgr/resources/content/passwordManager.js 1.11.4.3
mozilla/toolkit/components/passwordmgr/resources/content/passwordManager.js 1.14
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: