Closed Bug 343290 Opened 13 years ago Closed 13 years ago

Missing root in JS_NewPropertyIterator

Categories

(Core :: JavaScript Engine, defect, P3, major)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Keywords: crash, fixed1.8.0.7, fixed1.8.1, Whiteboard: [patch])

Attachments

(1 file)

There is a missing root in JS_NewPropertyIterator. In the general case (where we're dealing with a native object), there is a newborn root, and no calls to functions that can cause GC to happen to protect our new object. In the non-native case, however, we have a call to JS_Enumerate, which could allocate new objects and cause GC, destroying our newborn object.
Attached patch FixSplinter Review
Attachment #227770 - Flags: review?(brendan)
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [patch]
Attachment #227770 - Flags: review?(brendan) → review+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: blocking1.8.0.6?
Flags: in-testsuite-
This should go on both 1.8 and 1.8.0, right? not just 1.8.0? nominating
Flags: blocking1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
This landed on the 1.8 branch with JS1.7.
Keywords: fixed1.8.1
Attachment #227770 - Flags: approval1.8.1? → approval1.8.0.7?
Comment on attachment 227770 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #227770 - Flags: approval1.8.0.7? → approval1.8.0.7+
Flags: blocking1.8.0.7? → blocking1.8.0.7+
Fixed on the 1.8.0 branch.
Keywords: fixed1.8.0.7
Depends on: 362180
You need to log in before you can comment on or make changes to this bug.