343317 - Some Privacy & Security Preference sections missing in suiterunner builds

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Mark Banner (:standard8)]

We're missing the following sections from preferences in suiterunner builds:

Privacy & Security:
- Forms
- Passwords
- Master Passwords
- SSL
- Certificates
- Validation

It's because the relevant overlay definitions are missing from the jar.mn files for MOZ_XUL_APP=1 builds.

I have a patch.

I've also just discovered the "Forms" section is missing from the Tools menu. I can fix that here as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: jar.mn fix for wallet (checked in)

Comment 2

[Mark Banner (:standard8)]

Attachment: jar.mn changes for security manager

Comment 3

[Robert Kaiser]

Comment on attachment 227808 [details] [diff] [review]
jar.mn fix for wallet (checked in)

>Index: extensions/wallet/jar.mn
>===================================================================

Umm, is this directory really built for SeaMonkey only? If so, then the patch sounds OK - if not, I'd expect some |#ifdef MOZ_SUITE| stuff there as well...

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> (From update of attachment 227808 [details] [diff] [review] [edit])
> >Index: extensions/wallet/jar.mn
> >===================================================================
> 
> Umm, is this directory really built for SeaMonkey only? If so, then the patch
> sounds OK - if not, I'd expect some |#ifdef MOZ_SUITE| stuff there as well...
> 
Given that we're the only ones that have a preftree.xul and navigator.xul I thought that we would be able to get away without ifdefs. That's essentially how it worked before without any xul apps anyway.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 227809 [details] [diff] [review]
jar.mn changes for security manager

Index: security/manager/pki/resources/jar.mn
+#ifdef MOZ_SUITE
+% overlay chrome://communicator/content/pref/preftree.xul chrome://pippki/content/PrefOverlay.xul
+% overlay chrome://navigator/content/pageInfo.xul chrome://pippki/content/PageInfoOverlay.xul
+#endif

Hmm, I got this wrong. I didn't mean to put the ifdef MOZ_SUITE in here - it will mean that we'll get the same problem when we get to xulrunner builds.

I think the preftree.xul one is ok to include by itels, but the pageInfo one might cause problems with firefox.

The pageInfo.xul overlay gives us a security tab on Page Info I believe. Do we still wish to keep that? If so, we could possibly move the pageInfo stuff to /suite?

Thoughts?

Comment 6

[[e-mail]]

We should just be able to add the two overlay lines to a suite jar.mn
(firefox puts them in browser/base/jar.mn).

Comment 7

[Mark Banner (:standard8)]

Attachment: Include security pref and page info overlay definitions for suite.

This puts the two required overlay definitions for the security prefs and page info tab into suite/common/jar.mn as per Neil's suggestion.

Comment 8

[Robert Kaiser]

Comment on attachment 227814 [details] [diff] [review]
Include security pref and page info overlay definitions for suite.

>+% overlay chrome://navigator/content/pageInfo.xul chrome://pippki/content/PageInfoOverlay.xul

I'd prefer to have this in suite/browser instead of common, as page info is browser only...

Comment 9

[Mark Banner (:standard8)]

Attachment: Include security pref and page info overlay definitions for suite v2 (checked in)

Moved the page info definition to a new file suite/browser/jar.mn

Comment 10

[[e-mail]]

Comment on attachment 227808 [details] [diff] [review]
jar.mn fix for wallet (checked in)

I think you should at least try to get moa=mvl or someone on this.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 227808 [details] [diff] [review]
jar.mn fix for wallet (checked in)

mvl - Neil thinks you can give moa on this patch? We need these additional overlays in xul based suite so that we can display all our preferences properly.

See also comment 3 and comment 4.

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 227808 [details] [diff] [review]
jar.mn fix for wallet (checked in)

Sorry, I don't have time to do wallet reviews. (and I'm no sr)

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 227808 [details] [diff] [review]
jar.mn fix for wallet (checked in)

jag, can you sr this?

Comment 14

[Mark Banner (:standard8)]

Both patches checked in, therefore this should be fixed now.