We have our die_with_dignity debugging code in Bugzilla::CGI. But guess what? It doesn't do anything if it's inside of Bugzilla::CGI. Probably better to put it in Bugzilla.pm, where it would actually work.
Created attachment 227842 [details] [diff] [review] v1 Now, this one's complex. Moving commented code... :-D
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #227842 - Flags: review?(colin.ogilvie)
Comment on attachment 227842 [details] [diff] [review] v1 r=me on inspection - I don' think a lot can go wrong with a commented out code block ;)
Attachment #227842 - Flags: review?(colin.ogilvie) → review+
(In reply to comment #2) > I don' think a lot can go wrong with a commented out code block ;) This is not the right approach to review this patch. What you should do is to uncomment this block and make sure die_with_dignity() works correctly when being in Bugzilla.pm.
Comment on attachment 227842 [details] [diff] [review] v1 Note that if $cgi->header hasn't been called previously for .cgi scripts, a "malformed header" message is displayed in your browser instead of the expected error message (typically enter_bug.cgi which calls $cgi->header very late). The web server error log records both errors though, i.e. the "malformed header" one and the "real" error message. I checked, 2.22, where die_with_dignity() is still in globals.pl, has the same problem; so this is not a regression. That's the reason I r+ this patch, and also because leaving it in CGI.pm doesn't work. r=LpSolit
Attachment #227842 - Flags: review?(LpSolit) → review+
Checking in Bugzilla.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v <-- Bugzilla.pm new revision: 1.40; previous revision: 1.39 done Checking in Bugzilla/CGI.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v <-- CGI.pm new revision: 1.25; previous revision: 1.24 done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.