343390 -   followed by space at the end of an RTL line causes the text to be shifted to the left

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Uri Bernstein]

When an RTL line ends with one or more  s, followed by a space, the entire line is painted to the left of where it should be (as if the spaces where on the right side, instead of the left). Selection and caret movement in this case are also messed up.

This comes up especially in designMode, where  s are createded when typing multiple adjacent spaces.
 
This is a regression from my fix for bug 337135.

Testcase coming soon.

Comment 1

[Uri Bernstein]

Attachment: testcase

Comment 2

[Niro]

I can reproduce on Win XP.
Please change OS and Hardware to "All"

Comment 3

[Uri Bernstein]

Attachment: patch

Limit the fix for bug 337135 to the -moz-pre-wrap case only.

Comment 4

[Uri Bernstein]

Checked in:
Checking in layout/generic/nsTextFrame.cpp;
/cvsroot/mozilla/layout/generic/nsTextFrame.cpp,v  <--  nsTextFrame.cpp
new revision: 1.580; previous revision: 1.579
done

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Should the fix apply to 'white-space: pre' as well?  (Most callers that check 'white-space' should use the methods on nsStyleText for checking two values, although I see why this one might only apply to one value.)

Comment 6

[Uri Bernstein]

(In reply to comment #5)
> Should the fix apply to 'white-space: pre' as well?  (Most callers that check
> 'white-space' should use the methods on nsStyleText for checking two values,
> although I see why this one might only apply to one value.)
> 

In practice, bug 337135 did not occur in "pre" (the code I linked to in bug 337135 comment #6 is never reached in this case). Therefore, I thought it was unnecessary to apply the fix to "pre". The current bug didn't occur with "pre" either, so applying the fix to that case probably wouldn't hurt. Let me know if you want me to do that. 

Comment 7

[Uri Bernstein]

CC'ing dbaron for comment #6.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

No, the current situation is fine, then.

Comment 9

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).