Closed Bug 343514 Opened 14 years ago Closed 13 years ago

Typos in compare-locales.pl

Categories

(Toolkit Graveyard :: Build Config, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: jason.barnabe, Assigned: u88484)

Details

Attachments

(1 file, 1 obsolete file)

"Could not unZIP $file" -> "Couldn't unzip $file  (the rest of the script uses "couldn't")"
"add these keys to you localization" -> "add these keys to your localization"
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #228002 - Flags: first-review?
Attachment #228002 - Flags: first-review? → first-review?(mconnor)
Attachment #228002 - Flags: first-review?(mconnor) → first-review?(bugs.mano)
You should ask review from bsmedberg or l10n@mozilla.com (aka Axel & Pike) for this patch.
Summary: Typos in build-config.pl → Typos in compare-locales.pl
Attachment #228002 - Flags: first-review?(bugs.mano) → first-review?(benjamin)
Comment on attachment 228002 [details] [diff] [review]
patch v1

emacs has a fairly stupid syntax highlighter which thinks the apostrophe starts a string literal.
Attachment #228002 - Flags: first-review?(benjamin) → first-review-
Do you want me to remove the apostrophes in the other parts of the file?
I'm guessing that because of the review- for the first patch that you guys did not want to change the "could not" to "couldn't" but the "you" to "your" should still be changed.
Attachment #228002 - Attachment is obsolete: true
Attachment #280904 - Flags: review?(benjamin)
Attachment #280904 - Flags: review?(benjamin) → review?(l10n)
Severity: normal → trivial
Comment on attachment 280904 [details] [diff] [review]
Changes "you" to "your"

Not that I care about bug fixes for real bugs in this code anymore, but I can just as well r+ it as WONTFIX this bug.
Attachment #280904 - Flags: review?(l10n) → review+
(In reply to comment #6)
> (From update of attachment 280904 [details] [diff] [review])
> Not that I care about bug fixes for real bugs in this code anymore, but I can
> just as well r+ it as WONTFIX this bug.
> 

Is this actually needed or matter than? like is this code still used?
Status: NEW → ASSIGNED
Keywords: checkin-needed
All patches in bugs that are not blocking-firefox3+ or blocking1.9+ must receive approval1.9+ before they can be checked-in. Please request approval1.9 on the patch.
Keywords: checkin-needed
Attachment #280904 - Flags: approval1.9?
Comment on attachment 280904 [details] [diff] [review]
Changes "you" to "your"

a=bzbarsky
Attachment #280904 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in toolkit/locales/compare-locales.pl;
/cvsroot/mozilla/toolkit/locales/compare-locales.pl,v  <--  compare-locales.pl
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Assignee: jason_barnabe → supernova_00
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.