"ASSERTION: aPrevFrame must be the last continuation in its chain!" involving <dd>

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Layout
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: Uri Bernstein (Google))

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla1.9alpha1
PowerPC
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
###!!! ASSERTION: aPrevFrame must be the last continuation in its chain!: '!aPrevFrame || !aPrevFrame->GetNextContinuation()', file /Users/admin/trunk/mozilla/layout/base/nsFrameManager.cpp, line 671

This assertion was added in bug 299065, but I haven't tested to find out whether this bug is a more recent regression.
(Reporter)

Comment 1

12 years ago
Created attachment 228037 [details]
testcase
(Assignee)

Comment 2

12 years ago
Oh, great. A combination of multi-line generated content with "special" (block-inside-inline) frames. I'll see what I can do. 
(Assignee)

Comment 3

12 years ago
Created attachment 228042 [details]
testcase #2

This testcase demonstrates that this is a real bug: The text "new" is inserted before "ore" (which is the second line of the ":before" text), instead of after it.
Using this testcase it is possible to verify that the bug existed prior to the introduction of the assertion in bug 299065. The assertion just made it easier to find.
Also, notice the similarity to bug 327532.

I'm looking into nsCSSFrameConstructor::ContentInserted() for the best way to fix this. I hope to have a patch sometime soon.
(Assignee)

Comment 4

12 years ago
Created attachment 228048 [details] [diff] [review]
patch

This seems like the simplest and safest way to fix it.
Just make sure that we're inserting the new frame after the last continuation of the ":before" pseudo-element.
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #228048 - Flags: superreview?(roc)
Attachment #228048 - Flags: review?(roc)
Attachment #228048 - Flags: superreview?(roc)
Attachment #228048 - Flags: superreview+
Attachment #228048 - Flags: review?(roc)
Attachment #228048 - Flags: review+
(Assignee)

Comment 5

12 years ago
Checking in layout/base/nsCSSFrameConstructor.cpp;
/cvsroot/mozilla/layout/base/nsCSSFrameConstructor.cpp,v  <--  nsCSSFrameConstructor.cpp
new revision: 1.1242; previous revision: 1.1241
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
(Reporter)

Updated

12 years ago
Blocks: 343943
Depends on: 347853
(Assignee)

Comment 6

12 years ago
I accidentally mentioned the number of this bug in the check-in for bug 347853.
(Reporter)

Comment 7

11 years ago
Added reftest based on Uri's testcase (fails in 2006-07-01) and crashtest based on my testcase.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.