Tab reordering shortcuts can move tabs offscreen

RESOLVED FIXED in Firefox 2 beta1

Status

()

Firefox
Tabbed Browser
P2
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

({fixed1.8.1, regression})

unspecified
Firefox 2 beta1
fixed1.8.1, regression
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I'm running into various senarios in which the selected tab isn't visible.

One senario:
 1. Open many tabs.
 2. Select and focus the last tab.
 3. Press Ctrl+Home (selects the first tab).

One reason would be the use of this.selectedItem in the TabSelect handler. IIRC it still points to the previously selected tab at this point. Unfortunately, even after changing it to use this.childNodes[this.selectedIndex] (which should be fine, see updateCurrentBrowser), this handler doesn't really do its job.
Flags: blocking-firefox2?
So, Ctrl+Home moves that tab to the first position, so it misses the tabselect handler entirely.  Same problem with Ctrl+Left/Right and Ctrl+End, easy to reproduce.

We should add a tabmove handler to do the same as the tabselect handler and always ensure the tab is visible.  Not critical path for b1, but should be fixed.
Flags: blocking-firefox2? → blocking-firefox2+
Summary: Invisible selected tabs → Tab reordering shortcuts can move tabs offscreen
Target Milestone: --- → Firefox 2 beta2
Assignee: nobody → bugs.mano
Priority: -- → P2
Status: NEW → ASSIGNED

Updated

12 years ago
Attachment #228135 - Flags: review?(mconnor) → review+
Comment on attachment 228135 [details] [diff] [review]
patch

This should be safe enough for b1.
Attachment #228135 - Flags: approval1.8.1?
trunk: mozilla/toolkit/content/widgets/tabbrowser.xml 1.162
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Attachment #228135 - Flags: approval1.8.1? → approval1.8.1+
1.8 branch: mozilla/toolkit/content/widgets/tabbrowser.xml 1.103.2.52
Keywords: fixed1.8.1
Target Milestone: Firefox 2 beta2 → Firefox 2 beta1
You need to log in before you can comment on or make changes to this bug.