Closed Bug 343574 Opened 18 years ago Closed 18 years ago

Add support for blocking <notification>

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

Attachments

(1 file)

Add blocking notification
4.10 KB, patch
mconnor
: first-review+
Details | Diff | Splinter Review 
Blocking mode prevents access to the browser inside the <notificationbox> while it is shown.
This is the trunk patch. The branch will need a small change to handle alpha transparency differently.
Attachment #228057 - Flags: first-review?(mconnor)
Comment on attachment 228057 [details] [diff] [review]
Add blocking notification

Looks good.  Neil, can you get this into trunk tomorrow?
Attachment #228057 - Flags: first-review?(mconnor) → first-review+
checked in
On Linux trunk, the page turns white (bgcolor) after the notification is added. Maybe there's an issue with canvas transparency.

I see the platform is Mac, maybe that should be All?
Hasn't this bug been FIXED already (except for possible follow up bugs)?

Anyway, please don't check in on the 1.8 branch without a fix for bug 347247 (blocking notifications might not be dismissable without a mouse).
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: