343581 - Uninstaller removed required system folder 'C:\Documents and Settings\All Users\Desktop'

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Stefan Sitter [:ssitter]]

The Bon Echo/Sunbird Uninstaller removed the required system folder 'C:\Documents and Settings\All Users\Desktop' when running.

Tested with BonEcho (20060704-mozilla1.8) installer and Sunbird (20060704-trunk) installer on fresh installed Windows 2000 system.


Steps to Reproduce:
1. System is running as admin user. Perform default installation of BonEcho.
2. Check that BonEcho is running.
3. Perform uninstallation of BonEcho.


Actual Results:
After install a shortcut icon is created in shared desktop folder 'C:\Documents and Settings\All Users\Desktop'. This icon is the only element in that folder.

During uninstall the entire folder 'C:\Documents and Settings\All Users\Desktop' is removed. A system error dialog is displayed that Windows can not find the required system folder 'C:\Documents and Settings\All Users\Desktop'.


Expected Results:
System folder 'C:\Documents and Settings\All Users\Desktop' must not be removed during uninstall.


Additional Information:
Happens only if the BonEcho/Sunbird icon is the only element in that folder.

Comment 1

[Robert Strong (they/them - no direct email)]

Stefan, thanks for catching this. I'll submit a patch shortly

Comment 2

[Stefan Sitter [:ssitter]]

Found during additional testing: Happens also with user specific Desktop directory when installed as restricted user.
Same happens with program directory e.g. C:\xyz\BonEcho - if BonEcho is the only element C:\xyz will be removed too. (But that is less critical I think)

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: Calendar - protect against desktop, quicklaunch, and startmenu deletion

This also removes adding the quicktime plugin as is used by Firefox.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: Firefox - protect against deletion of Desktop, Quicklaunch, and StartMenu directories

Comment 5

[Robert Strong (they/them - no direct email)]

btw: this also protects against removing directories above the install directory but that is broken without this patch due to a typo. :(

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 228072 [details] [diff] [review]
Firefox - protect against deletion of Desktop, Quicklaunch, and StartMenu directories

r=sspitzer

nit:  "gaurd" is misspelled

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 228072 [details] [diff] [review]
Firefox - protect against deletion of Desktop, Quicklaunch, and StartMenu directories

r=Sir Seth per comment #6 and I'll fix the typo in the comment before checking in. Thanks!

Comment 8

[Robert Strong (they/them - no direct email)]

Firefox patch checked in to trunk. Leaving open for the Sunbird patch.

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 228072 [details] [diff] [review]
Firefox - protect against deletion of Desktop, Quicklaunch, and StartMenu directories

Tested using a trunk tbox build and all is well. Requesting 1.8.1

Comment 10

[Matthew (lilmatt) Willis]

Comment on attachment 228071 [details] [diff] [review]
Calendar - protect against desktop, quicklaunch, and startmenu deletion

r=lilmatt

Comment 11

[Robert Strong (they/them - no direct email)]

Comment on attachment 228071 [details] [diff] [review]
Calendar - protect against desktop, quicklaunch, and startmenu deletion

Calendar patch checked in to trunk and branch

Comment 12

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

We definitely want this for beta1. Letting it bake a bit longer before approving, though.

Comment 14

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH