should preferences.xml and scrollbox.xml check the document in notify()?

RESOLVED INACTIVE

Status

()

Toolkit
XUL Widgets
RESOLVED INACTIVE
12 years ago
2 days ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: mano)

Tracking

Trunk
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

should preferences.xml and scrollbox.xml check the document in notify()?

here's the change in question:

>+      <method name="notify">
>+        <parameter name="aTimer"/>
>+        <body>
>+        <![CDATA[
>+          if (!document)
>+            aTimer.cancel();
>+

asaf writes:

This doesn't make sense to me, but as you noted this is also done in the
preferences bindings (with "new options dialog" blame comment). Keep this here
but please file a bug on this (for both bindings).
Created attachment 247587 [details] [diff] [review]
remove it on trunk
Assignee: nobody → mano
Status: NEW → ASSIGNED
Attachment #247587 - Flags: first-review?(gavin.sharp)
Comment on attachment 247587 [details] [diff] [review]
remove it on trunk

>Index: toolkit/content/widgets/preferences.xml

>+        <![CDATA[          

nit: trailing whitespace

I wish I knew why this was added in the first place... r=me if you test to make that increasing the timeout and closing the window while the timer is active doesn't cause trouble.
Attachment #247587 - Flags: first-review?(gavin.sharp) → first-review+

Comment 3

2 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.