343587 - what's a good toolkit.scrollbox.clickToScroll.scrollDelay default?

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

what's a good toolkit.scrollbox.clickToScroll.scrollDelay default?

asaf suggested I ping the usual suspects for a recommendation.

this comes from bug #342906 where I've chosen a 200 ms slack timer.

asaf thinks 100 ms.

note, each time the timer fires (while you are clicking and holding the scroll button) we'll scroll a tab at at time.

Comment 1

[Asaf Romano (gone)]

This has to block if we're keeping the scroll buttons.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

This won't block release, but if we can get some good consensus on a value we'd take the patch. Right now it seems somewhat pokey, but functional.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Having tested this a bit, I find that at 100ms it's hard to read the titles on the tabs as they go by. I played with numbers, and think that 150ms would be better.

</beltzner-nitpick>

Comment 4

[(not reading, please use [e-mail] instead)]

fwiw: I'll try out 100 vs 150 ms and see if it feels better.

(ben / peter, can you try too?)

the patch would be trivial, so I'll whip it up.

Comment 5

[Asaf Romano (gone)]

Attachment: 150

this has r=beltzner.

Landed on trunk:
Checking in toolkit/content/widgets/scrollbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/scrollbox.xml,v  <--  scrollbox.xml
new revision: 1.17; previous revision: 1.16
done
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.651; previous revision: 3.650
done

Comment 6

[Asaf Romano (gone)]

Oops, checked this in before I've seen comment 4, sorry Seth.

Comment 7

[(not reading, please use [e-mail] instead)]

> Oops, checked this in before I've seen comment 4, sorry Seth.

no problem.  FWIW, 150 ms seems fine to me.

thanks for taking care of this and driving it in for 2.0b2.

Comment 8

[Asaf Romano (gone)]

1.8 branch:
mozilla/toolkit/content/widgets/scrollbox.xml 1.3.52.6
mozilla/modules/libpref/src/init/all.js 3.585.2.44