Closed Bug 343587 Opened 15 years ago Closed 15 years ago

what's a good toolkit.scrollbox.clickToScroll.scrollDelay default?

Categories

(Firefox :: Tabbed Browser, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2 beta2

People

(Reporter: moco, Assigned: mano)

References

Details

(Keywords: fixed1.8.1, Whiteboard: [would take patch])

Attachments

(1 file)

what's a good toolkit.scrollbox.clickToScroll.scrollDelay default?

asaf suggested I ping the usual suspects for a recommendation.

this comes from bug #342906 where I've chosen a 200 ms slack timer.

asaf thinks 100 ms.

note, each time the timer fires (while you are clicking and holding the scroll button) we'll scroll a tab at at time.
This has to block if we're keeping the scroll buttons.
Flags: blocking-firefox2?
This won't block release, but if we can get some good consensus on a value we'd take the patch. Right now it seems somewhat pokey, but functional.
Flags: blocking-firefox2? → blocking-firefox2-
Whiteboard: [would take patch]
Target Milestone: --- → Firefox 2 beta2
Having tested this a bit, I find that at 100ms it's hard to read the titles on the tabs as they go by. I played with numbers, and think that 150ms would be better.

</beltzner-nitpick>
fwiw: I'll try out 100 vs 150 ms and see if it feels better.

(ben / peter, can you try too?)

the patch would be trivial, so I'll whip it up.

Status: NEW → ASSIGNED
Attached patch 150Splinter Review
this has r=beltzner.

Landed on trunk:
Checking in toolkit/content/widgets/scrollbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/scrollbox.xml,v  <--  scrollbox.xml
new revision: 1.17; previous revision: 1.16
done
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.651; previous revision: 3.650
done
Assignee: sspitzer → bugs.mano
Attachment #230766 - Flags: review+
Attachment #230766 - Flags: approval1.8.1?
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Oops, checked this in before I've seen comment 4, sorry Seth.
> Oops, checked this in before I've seen comment 4, sorry Seth.

no problem.  FWIW, 150 ms seems fine to me.

thanks for taking care of this and driving it in for 2.0b2.

Priority: P1 → --
Hardware: All → PC
Attachment #230766 - Flags: approval1.8.1? → approval1.8.1+
1.8 branch:
mozilla/toolkit/content/widgets/scrollbox.xml 1.3.52.6
mozilla/modules/libpref/src/init/all.js 3.585.2.44
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.