Status

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: mattwillis, Assigned: mattwillis)

Tracking

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

12 years ago
Nuprefs (bug 333923) has baked for a while. Now that we've announced the end of xpfe support, we can remove the old preferences.
(Assignee)

Comment 1

12 years ago
Created attachment 228094 [details] [diff] [review]
rev0 - removes old preferences
Attachment #228094 - Flags: first-review?(jminta)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

12 years ago
Created attachment 228144 [details] [diff] [review]
rev1 - adds overlays I missed
Attachment #228094 - Attachment is obsolete: true
Attachment #228144 - Flags: first-review?(jminta)
Attachment #228094 - Flags: first-review?(jminta)

Comment 3

12 years ago
Comment on attachment 228144 [details] [diff] [review]
rev1 - adds overlays I missed

minused for breaking lightning.
Attachment #228144 - Flags: first-review?(jminta) → first-review-
(Assignee)

Comment 4

12 years ago
Created attachment 228258 [details] [diff] [review]
rev2 - doesn't break lightning
Attachment #228144 - Attachment is obsolete: true
Attachment #228258 - Flags: first-review?(jminta)
(Assignee)

Comment 5

12 years ago
Created attachment 228826 [details] [diff] [review]
rev3 - fixes stuff jminta found
Attachment #228258 - Attachment is obsolete: true
Attachment #228826 - Flags: first-review?(jminta)
Attachment #228258 - Flags: first-review?(jminta)
(Assignee)

Comment 6

12 years ago
(In reply to comment #5)
> Created an attachment (id=228826) [edit]
> rev3 - fixes stuff jminta found

jminta found:
 - editCategories.xul was still using prefs.dtd
 - lightning-preferences.xul was defining %preferencesDTD which mail's prefwindow already had

Comment 7

12 years ago
Comment on attachment 228826 [details] [diff] [review]
rev3 - fixes stuff jminta found

 calendar.jar:
 %   content calendar %content/calendar/
 #ifndef MOZ_SUNBIRD
 %   overlay chrome://browser/content/browser.xul chrome://calendar/content/calExtOverlay.xul
 %   overlay chrome://communicator/content/tasksOverlay.xul chrome://calendar/content/calendarOverlay.xul
-%   overlay chrome://communicator/content/pref/preftree.xul chrome://calendar/content/pref/prefOverlay.xul
-%   overlay chrome://communicator/content/pref/pref-appearance.xul chrome://calendar/content/pref/prefOverlay.xul
 %   overlay chrome://messenger/content/mailWindowOverlay.xul chrome://calendar/content/calExtOverlay.xul
 %   overlay chrome://messenger/content/messengercompose/messengercompose.xul chrome://calendar/content/calExtOverlay.xul
 *   content/calendar/contents.rdf (content/contents.rdf)
 *   skin/classic/calendar/contents.rdf (skin/classic/contents.rdf)
 *   skin/modern/calendar/contents.rdf (skin/modern/contents.rdf)
+%   skin calendar modern/1.0 %skin/modern/calendar/
 #endif
 %   skin calendar classic/1.0 %skin/classic/calendar/
-%   skin calendar modern/1.0 %skin/modern/calendar/
 *   content/calendar/applicationUtil.js (content/applicationUtil.js)
The modern stuff definitely isn't relevant to this patch.  We need a followup to deal with the whole #ifndef MOZ_SUNBIRD thing.

r=jminta with that
Attachment #228826 - Flags: first-review?(jminta) → first-review+
(Assignee)

Comment 8

12 years ago
(In reply to comment #7)
> (From update of attachment 228826 [details] [diff] [review] [edit])
> The modern stuff definitely isn't relevant to this patch.
No worries. It was removed from cvs in bug 343990

> We need a follow up to deal with the whole #ifndef MOZ_SUNBIRD thing.
Spun off as bug 344447

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

11 years ago
Component: Sunbird Only → Preferences
QA Contact: sunbird → preferences
You need to log in before you can comment on or make changes to this bug.