Having a minimize box for a confirmation dialog is not that great.
Created attachment 228119 [details] [diff] [review] Patch1 Switching to openDialog
Comment on attachment 228119 [details] [diff] [review] Patch1 onLoad in resetpassword.js uses this test if ("arguments" in window) Does that still work?
Created attachment 228169 [details] [diff] [review] Patch2 the if ("arguments" in window) is correct, but there was a problem. nsIDialogParamBlock wasn't declared, same problem in password.js
Comment on attachment 228169 [details] [diff] [review] Patch2 r=kengert
Attachment #228169 - Flags: review+
Does security/ require sr? If not, someone should check this in...
thanks for making me aware, I'll check it in shortly
fixed on trunk, thanks a lot for the patch
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
This caused regression bug 369098. When I reviewed your patch, I failed to catch that you are introducing a duplicate declaration in file password.js Removing that line fixes it for me. I'll back out that line, it's an obvious mistake.
You need to log in before you can comment on or make changes to this bug.