Closed Bug 343612 Opened 18 years ago Closed 18 years ago

Reset master password confirmation dialog should be opened as a dialog.

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: boissomag, Assigned: KaiE)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch2
3.83 KB, patch
KaiE
: review+
Details | Diff | Splinter Review 
Having a minimize box for a confirmation dialog is not that great.
Attached patch Patch1 (obsolete) — — Splinter Review 
Switching to openDialog
Attachment #228119 - Flags: review?(kengert)
Comment on attachment 228119 [details] [diff] [review]
Patch1

onLoad in resetpassword.js uses this test

  if ("arguments" in window) 

Does that still work?
Attached patch Patch2 — — Splinter Review 
the if ("arguments" in window) is correct, but there was a problem. nsIDialogParamBlock wasn't declared, same problem in password.js
Attachment #228119 - Attachment is obsolete: true
Attachment #228119 - Flags: review?(kengert)
Comment on attachment 228169 [details] [diff] [review]
Patch2

r=kengert
Attachment #228169 - Flags: review+
Does security/ require sr? If not, someone should check this in...
thanks for making me aware, I'll check it in shortly
fixed on trunk, thanks a lot for the patch
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
This caused regression bug 369098.

When I reviewed your patch, I failed to catch that you are introducing a duplicate declaration in file password.js
Removing that line fixes it for me.

I'll back out that line, it's an obvious mistake.
Blocks: 369098
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: