343616 - Launching an unknown protocol in a new tab (when no tabs are open) causes tab close 'x' buttons to not appear

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Gids Goldberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060704 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060704 Minefield/3.0a1

When no tabs are open and you launch an unknown protocol into a new tab, the tab close 'x' buttons don't appear on the two tabs.

Launching a subsequent tab draws tab close 'x' buttons on all 3 tabs. 


Reproducible: Always

Steps to Reproduce:
1.Start a Firefox window with no tabs open
2.In the Location Bar type test://test and press Alt+Enter
3.Close the warning dialog that appears

Actual Results:  
The two tabs don't have close 'x' buttons.

Expected Results:  
The two tabs should have close 'x' buttons.

Comment 1

[Gids Goldberg]

I also see this on the branch, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060704 BonEcho/2.0a3

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Yeesh, this is an old bug. I can reproduce it in Firefox 1.5.0.4, though it has no visible affects there since there are no close buttons on the tabs (the exception thrown is the same, though). addTab is calling loadURIWithFlags, which has the comment "throws for unknown schemes", without catching any possible exceptions. Sounds like this just needs a try/catch block.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

*** Bug 220838 has been marked as a duplicate of this bug. ***

Comment 4

[Wayne Mery (:wsmwk)]

got fixed at some point
WFM Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre