343640 - Disable building old calendar extension

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

Since we're deprecating the old XPI in favour of Lightning, and since we are removing xpfe support, we need to make changes to configure.in to reflect that.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - no more xpfe

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev1 - disables --enable-calendar entirely

Comment 3

[Matthew (lilmatt) Willis]

Attachment: rev2 - the right patch this time

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 228158 [details] [diff] [review]
rev2 - the right patch this time

r=dmose

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 228158 [details] [diff] [review]
rev2 - the right patch this time

Requesting r? from bsmedberg for sanity

Comment 6

[Matthew (lilmatt) Willis]

Attachment: part b - rev0 - calendar only

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 228158 [details] [diff] [review]
rev2 - the right patch this time

Moving to shaver 'cause bsmedberg is moving

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 228234 [details] [diff] [review]
part b - rev0 - calendar only

r=mvl

Comment 9

[Matthew (lilmatt) Willis]

(In reply to comment #8)
> (From update of attachment 228234 [details] [diff] [review] [edit])
> r=mvl

this patch checked in on MOZILLA_1_8_BRANCH and trunk

Comment 10

[Benjamin Smedberg]

Comment on attachment 228158 [details] [diff] [review]
rev2 - the right patch this time

I don't see the closing paren to match the MOZ_ARG_ENABLE_BOOL... am I missing something?

Comment 11

[Matthew (lilmatt) Willis]

(In reply to comment #10)
> (From update of attachment 228158 [details] [diff] [review] [edit])
> I don't see the closing paren to match the MOZ_ARG_ENABLE_BOOL... am I missing
> something?

No. I'm a moron and didn't notice the error when I "tested" it.

Comment 12

[Matthew (lilmatt) Willis]

Attachment: rev3 - now with 100% more close parens

Comment 13

[Matthew (lilmatt) Willis]

(In reply to comment #12)
> Created an attachment (id=228980) [edit]
> rev3 - now with 100% more close parens

patch checked in on trunk. leaving open to land on branch after baking and once Firefox 2 beta 1 craziness dies down.

Comment 14

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This broke the firefox tinderbox.

Comment 15

[Matthew (lilmatt) Willis]

(In reply to comment #14)
> This broke the firefox tinderbox.

Backed out (around an hour ago).
I've fixed the bustage locally, but am waiting for all the tinders to go green before attempting landing again.

Comment 16

[Matthew (lilmatt) Willis]

(In reply to comment #15)
> I've fixed the bustage locally, but am waiting for all the tinders to go green
> before attempting landing again.

Landed again.

Comment 17

[Matthew (lilmatt) Willis]

(In reply to comment #16)
> Landed again.

Backed out again. >:(

Comment 18

[Andrew Schultz]

Comment on attachment 228980 [details] [diff] [review]
rev3 - now with 100% more close parens

don't you need to remove MOZ_CALENDAR from autoconf.mk.in?

Comment 19

[Matthew (lilmatt) Willis]

(In reply to comment #18)
> (From update of attachment 228980 [details] [diff] [review] [edit])
> don't you need to remove MOZ_CALENDAR from autoconf.mk.in?

If I was removing it entirely, yes. We're just preventing you from building it by using --enable-calendar. If we decide to remove MOZ_CALENDAR, then yes, it's important.

The biggest problem was last night I was tired and used AC_DEFINE instead of AC_SUBST. This is fixed.

Checked in to trunk and fingers are crossed.

Comment 20

[Matthew (lilmatt) Willis]

(In reply to comment #19)
> Checked in to trunk and fingers are crossed.

We went green.
Time to let it bake before asking about branch.

Comment 21

[Matthew (lilmatt) Willis]

Attachment: rev4 - What finally worked.

Comment 22

[Mike Connor [:mconnor]]

Comment on attachment 229175 [details] [diff] [review]
rev4 - What finally worked.

a=mconnor on behalf of drivers for this calendar-only configure change (has bsmedberg's review as well)

Comment 23

[Matthew (lilmatt) Willis]

rev4 landed on MOZILLA_1_8_BRANCH

-> FIXED