User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:22.214.171.124) Gecko/20060508 Firefox/126.96.36.199 Build Identifier: Xulrunner trunk In nsCommandManager, there is an inconsistency between AddCommandObserver and RemoveCommandObserver in how the object passed as nsIObserver is casted to nsISupports to do operations on the observer array. In the former, it's a QI, but the latter uses an implicit static cast. This, depending on the observer's interface map, may lead to spurious failures of RemoveCommandObserver and object leaks. Reproducible: Always
Created attachment 228146 [details] [diff] [review] Change RemoveCommandObserver to QueryInterface a nsISupports from nsIObserver
Assignee: nobody → mhz
Status: UNCONFIRMED → NEW
Ever confirmed: true
Fix checked in. Thanks for the patch!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.