Closed Bug 343667 Opened 18 years ago Closed 18 years ago

Remove unused xpinstall installer bits

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(1 file)

Now that we're using NSIS, the pieces from the old (and out of date) xpinstall installer can be removed.
Removes files we're no longer using
Attachment #228182 - Flags: first-review?(jminta)
Comment on attachment 228182 [details] [diff] [review]
rev0 - removes old xpinstall files

r=jminta, but I'm just going on instinct here.  I'd like rob_strong to look over it too.
Attachment #228182 - Flags: second-review?(robert.bugzilla)
Attachment #228182 - Flags: first-review?(jminta)
Attachment #228182 - Flags: first-review+
I know that the xpinstall based installer isn't working but are you sure you really want to remove the pre-existing code since it could be fixed and thereby give you an os/2 installer?
(In reply to comment #3)
> I know that the xpinstall based installer isn't working but are you sure you
> really want to remove the pre-existing code since it could be fixed and thereby
> give you an os/2 installer?

I think an OS/2 or Linux installer are not critical. I'd rather remove the old stuff, focus solely on the Windows NSIS installer, and if we _really_ need xpinstall later, pull it from the CVS/Attic

(In reply to comment #4)
> I think an OS/2 or Linux installer are not critical. I'd rather remove the old
> stuff, focus solely on the Windows NSIS installer, and if we _really_ need
> xpinstall later, pull it from the CVS/Attic
> 
Why are we removing this stuff rather than actually having the discussion about whether we want xpinstall?  It seems we're doing work now when we're not sure we even want the work done.
If we keep nsinstall, we need to keep it working. So both ways take work.
(In reply to comment #6)
> If we keep nsinstall, we need to keep it working. So both ways take work.

So let's not double the work by maintaining an xpinstall installer?
Comment on attachment 228182 [details] [diff] [review]
rev0 - removes old xpinstall files

Cleanup is good. :P
Attachment #228182 - Flags: second-review?(robert.bugzilla) → second-review+
patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
(In reply to comment #9)
> patch checked in on MOZILLA_1_8_BRANCH and trunk
> 
> -> FIXED

Removing Header.bmp and Watermark.bmp pissed off toolkit/mozapps/installer/windows/wizard. We need to figure out if we want that, and if not how to disable it.

Backed out the part of the patch regarding those two files and the Makefiles. Did NOT back out all the xpinstall .jst removals.

Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #10)
> Fixed the orange by deleting "installer.cfg" from Makefile.in.

The need for the bitmaps for the wizard remains. I'm tempted to close this and worry about that later.

-> FIXED
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Mass move of all Installer bugs to General per ctalbert.
Component: Installer → General
The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!
QA Contact: installer → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: