343667 - Remove unused xpinstall installer bits

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Matthew (lilmatt) Willis]

Now that we're using NSIS, the pieces from the old (and out of date) xpinstall installer can be removed.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - removes old xpinstall files

Removes files we're no longer using

Comment 2

[Joey Minta]

Comment on attachment 228182 [details] [diff] [review]
rev0 - removes old xpinstall files

r=jminta, but I'm just going on instinct here.  I'd like rob_strong to look over it too.

Comment 3

[Robert Strong (they/them - no direct email)]

I know that the xpinstall based installer isn't working but are you sure you really want to remove the pre-existing code since it could be fixed and thereby give you an os/2 installer?

Comment 4

[Matthew (lilmatt) Willis]

(In reply to comment #3)
> I know that the xpinstall based installer isn't working but are you sure you
> really want to remove the pre-existing code since it could be fixed and thereby
> give you an os/2 installer?

I think an OS/2 or Linux installer are not critical. I'd rather remove the old stuff, focus solely on the Windows NSIS installer, and if we _really_ need xpinstall later, pull it from the CVS/Attic

Comment 5

[Joey Minta]

(In reply to comment #4)
> I think an OS/2 or Linux installer are not critical. I'd rather remove the old
> stuff, focus solely on the Windows NSIS installer, and if we _really_ need
> xpinstall later, pull it from the CVS/Attic
> 
Why are we removing this stuff rather than actually having the discussion about whether we want xpinstall?  It seems we're doing work now when we're not sure we even want the work done.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

If we keep nsinstall, we need to keep it working. So both ways take work.

Comment 7

[Matthew (lilmatt) Willis]

(In reply to comment #6)
> If we keep nsinstall, we need to keep it working. So both ways take work.

So let's not double the work by maintaining an xpinstall installer?

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 228182 [details] [diff] [review]
rev0 - removes old xpinstall files

Cleanup is good. :P

Comment 9

[Matthew (lilmatt) Willis]

patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED

Comment 10

[Matthew (lilmatt) Willis]

(In reply to comment #9)
> patch checked in on MOZILLA_1_8_BRANCH and trunk
> 
> -> FIXED

Removing Header.bmp and Watermark.bmp pissed off toolkit/mozapps/installer/windows/wizard. We need to figure out if we want that, and if not how to disable it.

Backed out the part of the patch regarding those two files and the Makefiles. Did NOT back out all the xpinstall .jst removals.

Reopening.

Comment 11

[Matthew (lilmatt) Willis]

(In reply to comment #10)
> Fixed the orange by deleting "installer.cfg" from Makefile.in.

The need for the bitmaps for the wizard remains. I'm tempted to close this and worry about that later.

-> FIXED

Comment 12

[Marcia Knous [:marcia]]

Mass move of all Installer bugs to General per ctalbert.

Comment 13

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!