343687 - It shouldn't be possible to check spell on a readonly <textbox>

Status: RESOLVED INVALID

(Toolkit :: UI Widgets, defect)

Description

[Florian Quèze [:florian]]

The context menu of <textbox> elements has an item "Spell check this field" even if the readonly attribute is set to true.

If the user enables spell check and then picks a suggestion in the list, the value of the field is modified. That shouldn't be possible on a readonly textbox.

Steps to reproduce:
1. Open the Page Info window
2. In the general tab, right click "text/html" (for example).

Comment 1

[Florian Quèze [:florian]]

Attachment: patch v1 (1.8 branch)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

You should check the property and not the attribute (readonly="fsdof" should not prevent spellcheck).

Comment 3

[Florian Quèze [:florian]]

Attachment: patch v2 (1.8 branch)

(In reply to comment #2)
> You should check the property and not the attribute (readonly="fsdof" should
> not prevent spellcheck).
> 

First I tried to check the property but it didn't work, so I used the attribute instead. I have just noticed that the property isn't hard to fix (if I understand this file well).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Oh, the patch from bug 318208 didn't land on the branch.

Comment 5

[Florian Quèze [:florian]]

Attachment: patch v3

Updated patch. Bug 318208 is now fixed in both the trunk and the 1.8 branch.

Comment 6

[Brett Wilson]

This bug will be invalid when bug 336799 lands, which removes the spellcheck UI from XUL.

Comment 7

[Peter Kasting]

Actually, this should have been fixed by my patch for bug 339127.