343709 - No way to skin Undo Close Tab menuitem without using English

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060705 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060705 BonEcho/2.0a3

Undo Close Tab menuitem has only the following associations:

label = Undo Close Tab menuitem 
accesskey = U

If one tries to skin the menuitem using the accesskey, then the Uninstall button in the Addons manager loses its skin because it also has accesskey = U.

The only remaining association is the label, which is in English.

This will fail in localizations other than English.

Reproducible: Always




Note that the context menu uses accesskey = U for the Undo function. There are apparently other items that use this accesskey. Do an attributes search in DOMi to see everything this access key is used for.

This Undo close Tab menuitem uses the accesskey U to call the command undoCloseTab or something. Ideally it would be something along the lines of:

undoCloseTabItem.setAttribute("command", undoCloseTab); or whatever the Undo Close Tabs command is.

This would allow us themers to put in a single selector to address the menuitem wherever it appears in the browser (e.g.--main context menu, History dropdown menu, tab context menu, etc.). We would use:

menuitem[command="undoCloseTab"] {etc.}

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: add id attr for identification by themers