JS_ASSERT(JSVAL_TO_OBJECT(v) == OBJ_GET_PARENT(cx, thisp));

VERIFIED FIXED in mozilla1.9alpha1

Status

()

Core
JavaScript Engine
P1
normal
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: bc, Assigned: mrbkap)

Tracking

({regression, verified1.8.0.7, verified1.8.1})

Trunk
mozilla1.9alpha1
regression, verified1.8.0.7, verified1.8.1
Points:
---
Bug Flags:
blocking1.8.1 +
blocking1.8.0.7 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
trunk and 1.8.0.5 winxp, prolly 1.8 as well.
(Reporter)

Updated

12 years ago
Assignee: general → mrbkap
(Reporter)

Updated

12 years ago
Blocks: 336601
(Reporter)

Updated

12 years ago
Flags: blocking1.8.1?
Flags: blocking1.8.0.6?
(Reporter)

Comment 1

12 years ago
Checking in regress-343713.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-343713.js,v  <--  regress-343713.js
initial revision: 1.1
Flags: in-testsuite+

Updated

12 years ago
No longer blocks: 336601
I think the patch for bug 336601 introduced this regression.  It obviously introduced the botching assertion.

/be
(Assignee)

Comment 3

12 years ago
Created attachment 228260 [details] [diff] [review]
Kill it
Attachment #228260 - Flags: review?(brendan)
mrbkap: but why?  Is not that assertion trying to uphold an invariant we believe never varies?  Or were we smoking something?

/be
Comment on attachment 228260 [details] [diff] [review]
Kill it

Argh, |with|.

/be
Attachment #228260 - Flags: review?(brendan) → review+
(Assignee)

Comment 6

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Keywords: regression

Updated

12 years ago
Blocks: 336601
(Reporter)

Comment 7

12 years ago
verified fixed 1.9a1 2006070603
Status: RESOLVED → VERIFIED

Updated

12 years ago
Flags: blocking1.8.1? → blocking1.8.1+
This fix landed as part of js1.7.

/be
Keywords: fixed1.8.1
(Reporter)

Comment 9

12 years ago
verified fixed 1.8.1 windows/macppc/linux 20060707
Keywords: fixed1.8.1 → verified1.8.1

Comment 10

12 years ago
Created attachment 232722 [details] [diff] [review]
1.0.x branch patch

regression fix needed for 1.0.9+
Comment on attachment 228260 [details] [diff] [review]
Kill it

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #228260 - Flags: approval1.8.0.7+
Flags: blocking1.8.0.7? → blocking1.8.0.7+
(Assignee)

Comment 12

12 years ago
Fixed on the 1.8.0 branch.
Keywords: fixed1.8.0.7
(Reporter)

Comment 13

12 years ago
verified fixed 1.8.0.7 20060818 windows/mac*/linux
Keywords: fixed1.8.0.7 → verified1.8.0.7
You need to log in before you can comment on or make changes to this bug.