Closed
Bug 343780
Opened 20 years ago
Closed 19 years ago
Preferences for locking homepage buttons don't work
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mkaply, Unassigned)
Details
(Keywords: fixed1.8.0.7, fixed1.8.1)
Attachments
(1 file)
|
1.34 KB,
patch
|
benjamin
:
review+
dveditz
:
approval1.8.0.7+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Currently there are three preferences designed for disabling the buttons for setting home page:
pref.browser.homepage.disable_button.current_page
pref.browser.homepage.disable_button.bookmark_page
pref.browser.homepage.disable_button.blank_page
They don't work.
This is because of a typo.
| Reporter | ||
Comment 1•20 years ago
|
||
No idea how I missed this last time I debugged it.
prefstring should be preference
This allows these prefs to be set to lock the buttons.
| Reporter | ||
Updated•19 years ago
|
Attachment #228325 -
Flags: review?(benjamin)
Updated•19 years ago
|
Attachment #228325 -
Flags: review?(benjamin) → review+
| Reporter | ||
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 2•19 years ago
|
||
Comment on attachment 228325 [details] [diff] [review]
change prefstring to preference
I'd love to get this on the branches.
It's a no risk fix for a typo that keeps a CCK function from working.
Attachment #228325 -
Flags: approval1.8.1?
Attachment #228325 -
Flags: approval1.8.0.7?
Comment 3•19 years ago
|
||
Comment on attachment 228325 [details] [diff] [review]
change prefstring to preference
a=schrep for drivers.
Attachment #228325 -
Flags: approval1.8.1? → approval1.8.1+
| Reporter | ||
Updated•19 years ago
|
Keywords: fixed1.8.1
Comment 4•19 years ago
|
||
Comment on attachment 228325 [details] [diff] [review]
change prefstring to preference
approved for 1.8.0 branch, a=dveditz for drivers
Attachment #228325 -
Flags: approval1.8.0.7? → approval1.8.0.7+
| Reporter | ||
Updated•19 years ago
|
Keywords: fixed1.8.0.7
You need to log in
before you can comment on or make changes to this bug.
Description
•