Closed Bug 343788 Opened 18 years ago Closed 18 years ago

Installation silently fails when trying to install an OpenSearch search engine that doesn't have an HTML result type

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: JasnaPaka, Assigned: Gavin)

References

(
URL
)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

make it a parse error, instead of silently refusing to load it
1.80 KB, patch
mozilla
: review+
mconnor
: superreview+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060703 BonEcho/2.0a3

Latest Bon Echo Build, clean profile.

1. Visit http://www.msblog.org/.
2. Try add OpenSearch modul ("Add MSBLOG Search").



Reproducible: Always

Actual Results:  
Nothing is happen. No error message in Error Console.


Link to search engine: http://www.msblog.org/search.xml
That engine has no "text/html" result type, only RSS (application/rss+xml), so we refuse to load it. If our RSS viewing is in good shape, perhaps we should accept RSS-only types and just load the feed...
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Summary: Cannot add search engine (OpenSearch) from MSBlog → Cannot add OpenSearch search engines that only have RSS result types
It'd be good to at least warn in that case, though, and not add the engine to the profile dir, only to have it fail to load at each subsequent startup.
This makes it fail earlier, was has the result of causing it to warn that the load fails. This is a stopgap until we decide to support RSS results.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #228385 - Flags: review?(joe)
Summary: Cannot add OpenSearch search engines that only have RSS result types → Installation silently fails when trying to install an OpenSearch search engine that doesn't have an HTML result type
Target Milestone: --- → Firefox 2 beta2
Version: unspecified → 2.0 Branch
I filed bug 343824 for considering supporting RSS result types.
Comment on attachment 228385 [details] [diff] [review]
make it a parse error, instead of silently refusing to load it

I wish we could give site authors specific info in the JS console in this case, but either way it's an improvement over what's there now.
Attachment #228385 - Flags: review?(joe) → review+
I filed bug 343829 about better JS console errors for invalid plugins.
Attachment #228385 - Flags: superreview?(mconnor)
Flags: blocking-firefox2?
Whiteboard: [patch-r?]
Flags: blocking-firefox2? → blocking-firefox2+
Attachment #228385 - Flags: superreview?(mconnor) → superreview+
Whiteboard: [patch-r?] → [checkin needed]
mozilla/browser/components/search/nsSearchService.js 	1.55
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [need-a]
Comment on attachment 228385 [details] [diff] [review]
make it a parse error, instead of silently refusing to load it

This is a low risk fix, it just makes the code fail earlier and show an error message, instead of failing silently.
Attachment #228385 - Flags: approval1.8.1?
Whiteboard: [need-a] → [a?]
Comment on attachment 228385 [details] [diff] [review]
make it a parse error, instead of silently refusing to load it

a=mconnor on behalf of drivers for checkin to the 1.8 branch
Attachment #228385 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [a?] → [checkin needed (1.8 branch)]
mozilla/browser/components/search/nsSearchService.js 	1.1.2.47
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
*** Bug 348509 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: