Closed Bug 343814 Opened 18 years ago Closed 18 years ago

Move PatchReader specific code into a separate module

Categories

(Bugzilla :: Attachments & Requests, enhancement)

Product:
Bugzilla
Component:
Attachments & Requests
Version:
2.23
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file, 1 obsolete file)

patch, v1.1
20.28 KB, patch
LpSolit
: review+
Details | Diff | Splinter Review 
Actually, these functions are in attachment.cgi, which makes it impossible to use outside this script. We should probably put it in a new Bugzilla::Attachment::PatchReader module.
Attached patch patch, v1 (obsolete) — — Splinter Review 

        Attachment #230746 -
        Flags: review?(myk)

    
  
Status: NEW → ASSIGNED

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, v1.1
        — 
          — Splinter Review
      

    


  
There is one call to ThrowCodeError() in get_unified_diff() and so we need Bugzilla::Error in PatchReader.pm too.

        Attachment #230746 -
        Attachment is obsolete: true

        Attachment #230879 -
        Flags: review?(myk)

        Attachment #230746 -
        Flags: review?(myk)

    
  
Flags: approval?

    
  

        Attachment #230879 -
        Flags: review?(myk)

    
    

    
  
On checkin, add "John Keiser <john@johnkeiser.com>" to the list of contributors in the new module.
Flags: approval? → approval+

    
    

    
  
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.119; previous revision: 1.118
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment/PatchReader.pm,v
done
Checking in Bugzilla/Attachment/PatchReader.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment/PatchReader.pm,v  <--  PatchReader.pm
initial revision: 1.1
done

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  

        Attachment #230879 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: