34383 - JS exception when I select the inbox on an imap server, and then use the twisty to close the imap server

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Comment 1

[(not reading, please use [e-mail] instead)]

I've wrapped the code in widgetglue.js with try and catch, so now the user 
gets this:

see bug #34383, specialFolder failure: [Exception... "Illegal value"  code: "-21
47024809" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "chrome://m
essenger/content/widgetglue.js Line: 74"]

re-assign to jefft, I think this is his JS.

this line raises the exception:

specialFolder = folderTree.selectedItems[0].getAttribute('SpecialFolder');

Comment 2

[jefft]

Have a fix. Ready for review.

Comment 3

[jefft]

Fix checked in.

Comment 4

[(not reading, please use [e-mail] instead)]

once I verify this is fixed, I'll remove my dump() statement.

Comment 5

[lchiang]

Did you remove your statement yet?

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Looks like this is still in, but just commented out:

224 // Given a URI we would like to return corresponding message folder here.
225 // An additonal input param which specifies whether or not to check folder 
226 // attributes (like if there exists a parent or is it a server) is also passed
227 // to this routine. Qualifying against those checks would return an existing 
228 // folder. Callers who don't want to check those attributes will specify the
229 // same and then this routine will simply return a msgfolder. This scenario
230 // applies to a new imap account creation where special folders are created
231 // on demand and hence needs to prior check of existence.
232 function GetMsgFolderFromUri(uri, checkFolderAttributes)
233 {
234     //dump("GetMsgFolderFromUri of " + uri + "\n");
235     var msgfolder = null;
236     try {
237         var resource = GetResourceFromUri(uri);
238         msgfolder = resource.QueryInterface(Components.interfaces.nsIMsgFolder);
239         if (checkFolderAttributes) {
240             if (!(msgfolder && (msgfolder.parent || msgfolder.isServer))) {
241                 msgfolder = null;
242             }
243         }
244     }
245     catch (ex) {
246         //dump("failed to get the folder resource\n");
247     }
248     return msgfolder;
249 }
250 

both dumps in 234 and 246 are commented out.  I'll ask Seth via AIM what he
wants done with this bug.

Note that I don't see the exception with build 2002-11-19-08, with all JS dumps
and debugging statements enabled.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

verified fixed, since I don't see the exception.  see the comment above.

if we need to track the removal of the JS dump, we can file that separately.