343893 - Add events for watching the addition and removal of tabs

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

See Firefox bug 322898

This would be good for us to have too.  I don't think Neil really likes the API (it fires redundant events), but if we're going to provide this functionality, A) we'll have to take the tabbox.xml piece with the move to toolkit anyway B) for extensions, having the same API would make sense.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: port of toolkit code

straight port of sspitzer's code

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Bug 343096 will fix the multiple events issue.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 228448 [details] [diff] [review]
port of toolkit code

what about TabMove?

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

This missed SM1.1.

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch v2

Comment 6

[[e-mail]]

Comment on attachment 248607 [details] [diff] [review]
patch v2

>+            // Support both the old "select" event and the new, redundant-but-in-toolkit
-but-no-longer-in-toolkit

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: v3

(In reply to comment #6)
> (From update of attachment 248607 [details] [diff] [review] [edit])
> >+            // Support both the old "select" event and the new, redundant-but-in-toolkit
> -but-no-longer-in-toolkit

Comment 8

[[e-mail]]

Comment on attachment 248697 [details] [diff] [review]
v3

Looks good but I haven't tested it.

>+            var evt = document.createEvent("UIEvents");
>+            evt.initUIEvent("TabMove", true, false, window, aSrcIndex);
>+
Isn't this event supposed to be dispatched?

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: v4

(In reply to comment #8)
> (From update of attachment 248697 [details] [diff] [review] [edit])
> Looks good but I haven't tested it.
> 
> >+            var evt = document.createEvent("UIEvents");
> >+            evt.initUIEvent("TabMove", true, false, window, aSrcIndex);
> >+
> Isn't this event supposed to be dispatched?

I guess so.

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 248831 [details] [diff] [review]
v4

Checked in on trunk.

Comment 11

[Robert Kaiser]

Comment on attachment 248831 [details] [diff] [review]
v4

a=me for 1.1

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checked in on branch (had to be edited to apply).