The default bug view has changed. See this FAQ.

Add events for watching the addition and removal of tabs

RESOLVED FIXED in seamonkey1.1final

Status

SeaMonkey
UI Design
--
enhancement
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Assigned: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com])

Tracking

({fixed-seamonkey1.1})

Trunk
seamonkey1.1final
x86
Windows XP
fixed-seamonkey1.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

See Firefox bug 322898

This would be good for us to have too.  I don't think Neil really likes the API (it fires redundant events), but if we're going to provide this functionality, A) we'll have to take the tabbox.xml piece with the move to toolkit anyway B) for extensions, having the same API would make sense.
Created attachment 228448 [details] [diff] [review]
port of toolkit code

straight port of sspitzer's code
Assignee: jag → cst
Status: UNCONFIRMED → ASSIGNED
Attachment #228448 - Flags: superreview?(neil)
Attachment #228448 - Flags: review?(jag)
Bug 343096 will fix the multiple events issue.
Attachment #228448 - Attachment is obsolete: true
Attachment #228448 - Flags: superreview?(neil)
Attachment #228448 - Flags: review?(jag)
Depends on: 343096
Whiteboard: [cst: wait for toolkit fix in bug 343096]
Comment on attachment 228448 [details] [diff] [review]
port of toolkit code

what about TabMove?
This missed SM1.1.
Whiteboard: [cst: wait for toolkit fix in bug 343096]
Target Milestone: seamonkey1.1alpha → seamonkey1.5alpha
Version: 1.8 Branch → Trunk
Created attachment 248607 [details] [diff] [review]
patch v2
Attachment #248607 - Flags: superreview?(neil)
Attachment #248607 - Flags: review?(neil)

Comment 6

10 years ago
Comment on attachment 248607 [details] [diff] [review]
patch v2

>+            // Support both the old "select" event and the new, redundant-but-in-toolkit
-but-no-longer-in-toolkit
Attachment #248607 - Flags: superreview?(neil)
Attachment #248607 - Flags: superreview-
Attachment #248607 - Flags: review?(neil)
Created attachment 248697 [details] [diff] [review]
v3

(In reply to comment #6)
> (From update of attachment 248607 [details] [diff] [review] [edit])
> >+            // Support both the old "select" event and the new, redundant-but-in-toolkit
> -but-no-longer-in-toolkit
Attachment #248607 - Attachment is obsolete: true
Attachment #248697 - Flags: superreview?(neil)
Attachment #248697 - Flags: review?(neil)

Comment 8

10 years ago
Comment on attachment 248697 [details] [diff] [review]
v3

Looks good but I haven't tested it.

>+            var evt = document.createEvent("UIEvents");
>+            evt.initUIEvent("TabMove", true, false, window, aSrcIndex);
>+
Isn't this event supposed to be dispatched?
Attachment #248697 - Flags: superreview?(neil)
Attachment #248697 - Flags: superreview+
Attachment #248697 - Flags: review?(neil)
Created attachment 248831 [details] [diff] [review]
v4

(In reply to comment #8)
> (From update of attachment 248697 [details] [diff] [review] [edit])
> Looks good but I haven't tested it.
> 
> >+            var evt = document.createEvent("UIEvents");
> >+            evt.initUIEvent("TabMove", true, false, window, aSrcIndex);
> >+
> Isn't this event supposed to be dispatched?

I guess so.
Attachment #248697 - Attachment is obsolete: true
Attachment #248831 - Flags: review?(neil)

Updated

10 years ago
Attachment #248831 - Flags: review?(neil) → review+
Comment on attachment 248831 [details] [diff] [review]
v4

Checked in on trunk.
Attachment #248831 - Flags: approval-seamonkey1.1?
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 11

10 years ago
Comment on attachment 248831 [details] [diff] [review]
v4

a=me for 1.1
Attachment #248831 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
Checked in on branch (had to be edited to apply).
Keywords: fixed-seamonkey1.1
Target Milestone: seamonkey1.5alpha → seamonkey1.1final
You need to log in before you can comment on or make changes to this bug.