Closed Bug 343893 Opened 15 years ago Closed 14 years ago

Add events for watching the addition and removal of tabs

Categories

(SeaMonkey :: UI Design, enhancement)

x86
Windows XP
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.1final

People

(Reporter: csthomas, Assigned: csthomas)

References

Details

(Keywords: fixed-seamonkey1.1)

Attachments

(1 file, 3 obsolete files)

See Firefox bug 322898

This would be good for us to have too.  I don't think Neil really likes the API (it fires redundant events), but if we're going to provide this functionality, A) we'll have to take the tabbox.xml piece with the move to toolkit anyway B) for extensions, having the same API would make sense.
Attached patch port of toolkit code (obsolete) — Splinter Review
straight port of sspitzer's code
Assignee: jag → cst
Status: UNCONFIRMED → ASSIGNED
Attachment #228448 - Flags: superreview?(neil)
Attachment #228448 - Flags: review?(jag)
Bug 343096 will fix the multiple events issue.
Attachment #228448 - Attachment is obsolete: true
Attachment #228448 - Flags: superreview?(neil)
Attachment #228448 - Flags: review?(jag)
Depends on: 343096
Whiteboard: [cst: wait for toolkit fix in bug 343096]
This missed SM1.1.
Whiteboard: [cst: wait for toolkit fix in bug 343096]
Target Milestone: seamonkey1.1alpha → seamonkey1.5alpha
Version: 1.8 Branch → Trunk
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #248607 - Flags: superreview?(neil)
Attachment #248607 - Flags: review?(neil)
Comment on attachment 248607 [details] [diff] [review]
patch v2

>+            // Support both the old "select" event and the new, redundant-but-in-toolkit
-but-no-longer-in-toolkit
Attachment #248607 - Flags: superreview?(neil)
Attachment #248607 - Flags: superreview-
Attachment #248607 - Flags: review?(neil)
Attached patch v3 (obsolete) — Splinter Review
(In reply to comment #6)
> (From update of attachment 248607 [details] [diff] [review] [edit])
> >+            // Support both the old "select" event and the new, redundant-but-in-toolkit
> -but-no-longer-in-toolkit
Attachment #248607 - Attachment is obsolete: true
Attachment #248697 - Flags: superreview?(neil)
Attachment #248697 - Flags: review?(neil)
Comment on attachment 248697 [details] [diff] [review]
v3

Looks good but I haven't tested it.

>+            var evt = document.createEvent("UIEvents");
>+            evt.initUIEvent("TabMove", true, false, window, aSrcIndex);
>+
Isn't this event supposed to be dispatched?
Attachment #248697 - Flags: superreview?(neil)
Attachment #248697 - Flags: superreview+
Attachment #248697 - Flags: review?(neil)
Attached patch v4Splinter Review
(In reply to comment #8)
> (From update of attachment 248697 [details] [diff] [review] [edit])
> Looks good but I haven't tested it.
> 
> >+            var evt = document.createEvent("UIEvents");
> >+            evt.initUIEvent("TabMove", true, false, window, aSrcIndex);
> >+
> Isn't this event supposed to be dispatched?

I guess so.
Attachment #248697 - Attachment is obsolete: true
Attachment #248831 - Flags: review?(neil)
Attachment #248831 - Flags: review?(neil) → review+
Comment on attachment 248831 [details] [diff] [review]
v4

Checked in on trunk.
Attachment #248831 - Flags: approval-seamonkey1.1?
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 248831 [details] [diff] [review]
v4

a=me for 1.1
Attachment #248831 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
Checked in on branch (had to be edited to apply).
Target Milestone: seamonkey1.5alpha → seamonkey1.1final
You need to log in before you can comment on or make changes to this bug.