Closed Bug 343897 Opened 15 years ago Closed 15 years ago

Microsummary bookmark in toolbar has incorrect hover highlight

Categories

(Firefox Graveyard :: Microsummaries, defect, P3)

2.0 Branch
PowerPC
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 2

People

(Reporter: pamg.bugs, Assigned: pamg.bugs)

References

()

Details

(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])

Attachments

(1 file, 2 obsolete files)

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060706 BonEcho/2.0a3

For at least one microsummary added to my Mac bookmark toolbar, the highlight on hover is incorrect.  (See attached screenshot.)  This bookmark came from the URL listed above and shows the error consistently (although it updates daily and I haven't tried it on other days). I haven't yet been able to find another microsummary that displays the same behavior.
Priority: -- → P3
Whiteboard: [myk-mss]
Target Milestone: --- → Firefox 2 beta2
Flags: blocking-firefox2? → blocking-firefox2+
Component: Bookmarks → Microsummaries
Whiteboard: [myk-mss]
Whiteboard: [mustfix]
Attached file wider Bookmark Bar hover images (obsolete) —
Assignee: nobody → kevin
Status: NEW → ASSIGNED
Attachment #229802 - Flags: approval1.8.1?
Comment on attachment 229802 [details]
wider Bookmark Bar hover images

This looks like the right fix to me, although I haven't built it yet on Mac.
I have; it works fine.
Comment on attachment 229802 [details]
wider Bookmark Bar hover images

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and mark fixed1.8.1 after doing so.
Attachment #229802 - Flags: approval1.8.1? → approval1.8.1+
Keywords: fixed1.8.1
This has already landed on branch.  Also landing on trunk and marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This may have regressed since the new theme landed; I'm seeing it again on my Mac, and have verified it on some other Macs as well. Looks just like attachment 228451 [details].
Status: RESOLVED → REOPENED
Keywords: fixed1.8.1
Resolution: FIXED → ---
Target Milestone: Firefox 2 beta2 → Firefox 2
It looks like the wider images posted here simply got overwritten with the old ones on the branch.  Re-landing these now.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
Sorry, my bad.  The new images were, in fact, new.  Landing longer versions of the new ones momentarily.
Attached file New wider hover images (obsolete) —
Pam, should this be fixed1.8.1, or is there something else to do here?
Yep, it's fixed.
Keywords: fixed1.8.1
Gah. This regressed again in the latest nightlies, most likely due to bug 348865.
Status: RESOLVED → REOPENED
Keywords: fixed1.8.1
Resolution: FIXED → ---
Depends on: 348837
Pam are you on this?
I can be, but last time I apparently changed the colors of the images inadvertently, which led to bug 348865.  I've also gotten confused about exactly which images are the latest set -- is it one of the sets in bug 348837, or are there newer ones? So I wonder if Jay could please make 280-pixel-wide versions of the latest images for bookmark-hover-right.png and bookmark-open-right.png?
Never mind -- I boldly made a new set of images from the ones currently checked in.  They're attached to bug 348865, and they should fix both that bug and this one.
Depends on: 348865
Attachment #233859 - Attachment is obsolete: true
Attachment #229802 - Attachment is obsolete: true
Whiteboard: [mustfix] → [Fx2 theme change]
Assignee: kevin → pamg.bugs
Status: REOPENED → NEW
Looks to be fixed by the new images from bug 348865
Status: NEW → RESOLVED
Closed: 15 years ago15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.