343897 - Microsummary bookmark in toolbar has incorrect hover highlight

Status: RESOLVED FIXED

(Firefox Graveyard :: Microsummaries, defect, P3)

Description

[Pam Greene]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060706 BonEcho/2.0a3

For at least one microsummary added to my Mac bookmark toolbar, the highlight on hover is incorrect.  (See attached screenshot.)  This bookmark came from the URL listed above and shows the error consistently (although it updates daily and I haven't tried it on other days). I haven't yet been able to find another microsummary that displays the same behavior.

Comment 1

[Pam Greene]

Attachment: Mac bookmark toolbar, hovering on microsummary

Comment 2

[Kevin Gerich]

Attachment: wider Bookmark Bar hover images

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 229802 [details]
wider Bookmark Bar hover images

This looks like the right fix to me, although I haven't built it yet on Mac.

Comment 4

[Pam Greene]

I have; it works fine.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 229802 [details]
wider Bookmark Bar hover images

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and mark fixed1.8.1 after doing so.

Comment 6

[Pam Greene]

This has already landed on branch.  Also landing on trunk and marking fixed.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

This may have regressed since the new theme landed; I'm seeing it again on my Mac, and have verified it on some other Macs as well. Looks just like attachment 228451 [details].

Comment 8

[Pam Greene]

It looks like the wider images posted here simply got overwritten with the old ones on the branch.  Re-landing these now.

Comment 9

[Pam Greene]

Sorry, my bad.  The new images were, in fact, new.  Landing longer versions of the new ones momentarily.

Comment 10

[Pam Greene]

Attachment: New wider hover images

Comment 11

[Mike Connor [:mconnor]]

Pam, should this be fixed1.8.1, or is there something else to do here?

Comment 12

[Pam Greene]

Yep, it's fixed.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Gah. This regressed again in the latest nightlies, most likely due to bug 348865.

Comment 14

[Mike Schroepfer]

Pam are you on this?

Comment 15

[Pam Greene]

I can be, but last time I apparently changed the colors of the images inadvertently, which led to bug 348865.  I've also gotten confused about exactly which images are the latest set -- is it one of the sets in bug 348837, or are there newer ones? So I wonder if Jay could please make 280-pixel-wide versions of the latest images for bookmark-hover-right.png and bookmark-open-right.png?

Comment 16

[Pam Greene]

Never mind -- I boldly made a new set of images from the ones currently checked in.  They're attached to bug 348865, and they should fix both that bug and this one.

Comment 17

[Mike Connor [:mconnor]]

Looks to be fixed by the new images from bug 348865