343909 - The 'History' menu's access key "i" should be changed (underline way to small)

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[u88484]

Comment 1

[u88484]

Attachment: compare history to bookmarks menu's access key

Comment 2

[u88484]

Attachment: patch

Patch which changes the access key from 'i' to 'y'...if this of course decided.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 228474 [details] [diff] [review]
patch

I think "s" works better than "y".

Comment 4

[u88484]

Attachment: Patch

Patch per comment 3, changes access key to "s"

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230105 [details] [diff] [review]
Patch

Thanks, Kurt. Do we need to rev the entity names for localizers? I don't think so, since they'll have xlated it ...

Comment 6

[Asaf Romano (gone)]

Comment on attachment 230105 [details] [diff] [review]
Patch

This is a bug specific to the en-US package so no need to rev the entity name, r=mano.

Comment 7

[u88484]

Comment on attachment 230105 [details] [diff] [review]
Patch

Trivial, no risk fix

Comment 8

[Aaron Leventhal]

s is definitely better than y. So this is good.

FYI, we actually have a FAQ on choosing accesskeys. Avoid  1 pixel thin lowercase letters like i or l in certain fonts. Avoid letters with descenders like y, q, g. It makes it too hard to see the underline.

More info here:
http://www.mozilla.org/access/keyboard/accesskey

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.52

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230105 [details] [diff] [review]
Patch

a=beltzner, single hand saluting this one as per an irc convo with connor last night.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.25.2.23

Comment 12

[Cross Bud]

I'm fond of the shortcut Alt+S
to submit my replies in most forums.

But now I found the shortcut has been occupied by fx for the bookmarks shortcut.
I wish that the staff can cancel this shortcut.

Please, Alt+S to submit is really vital for many forums users.

Comment 13

[u88484]

Mike, there are two threads on mozillazine complaining about alt+s being used or was used a lot to submit on forms and forums. Think we need to change the access key to something else, suggestions?

http://forums.mozillazine.org/viewtopic.php?t=446830
http://forums.mozillazine.org/viewtopic.php?t=452480

Comment 14

[Simon Bünzli]

(In reply to comment #13)
> alt+s being used or was used a lot to submit on forms and forums.

That's because of bug 348793 which changed that shortcut from Alt+S to Alt+Shift+S and has nothing to do with this bug (users who prefer Alt+S can get the former behavior by reverting ui.key.generalAccessKey to 18; then content accesskeys will once again overrule chrome ones - which was the main reason for the change).

Comment 15

[Ben Scott]

Can't say I'm a big fan of the new change, pretty much all forum software (vBulletin, IPB, phpBB, SMF, YaBB etc) uses alt+s as the shortcut for sending a post.

This change will annoy quite a few people, suggesting people change stuff in their theme won't help none techy users but probably force them to move to another browser instead.

Comment 16

[Keith J. Frank]

(In reply to comment #15)
> Can't say I'm a big fan of the new change, pretty much all forum software
> (vBulletin, IPB, phpBB, SMF, YaBB etc) uses alt+s as the shortcut for sending a
> post.
> 
> This change will annoy quite a few people, suggesting people change stuff in
> their theme won't help none techy users but probably force them to move to
> another browser instead.
> 
I agree. I am very much involved with Invision, and on Invision forums for most of my day. I was sooooooooooooooooo tempted to revert to the past version after the beta upgrade because the alt+s kept opening the history. To find the about:config fix, I had to search mozillazine for the keyword "accesskey", which non-html type people will most likely not search for, because the will not know what it is or what it does.

In all due respect, the people that will gripe about this are probably the ones that know how to research out the fix, but why should we? A web browser should be a tool to utilize a person's website, not override the designer/coder's intentions.

Comment 17

[Simon Bünzli]

(In reply to comment #15) and (In reply to comment #16)

As you could have read in comment #14, this bug is not to blame for your issues. In case you do have constructive feedback, please leave it in bug 349716 - otherwise please use the MozillaZine forums for venting.

Comment 18

[Lars Petersen]

I just wanna throw my vote in. I use ALT+S for submitting, lots of places! I never use history :P Not having it work is frustrating. I am coming to hate the history menu :P

Comment 19

[tommyjb]

Comment 18 is irrelevant here.  Please see comment 17.