Closed Bug 343913 Opened 18 years ago Closed 15 years ago

Too much space between radiogroups and checkbox groups in pref. window

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: ispiked, Assigned: Waldo)

References

Details

(Keywords: polish)

Attachments

(4 files)

Main tab
45.35 KB, image/png
Details
Tabs tab
31.42 KB, image/png
Details
Use thin separators
2.58 KB, patch
asaf
: review+
beltzner
: ui-review+
Details | Diff | Splinter Review
New spacing screenshot
42.68 KB, image/png
Details 
In the new prefs. window there is too much space between some groups of radio buttons and groups of checkboxes. 

E.g. in the Tabs tab and in the Downloads section of the Main tab.
Attached image Main tab — 

    
    

    
  

      
      
      
      

        Attached image
          
        Tabs tab
        — 
      

    


  

    
  
Blocks: pref-reorg
No longer blocks: 343832

    
    

    
  


  
We could make the separators thin if desired; I don't have an opinion one way or another on the current size.

Who reviews UI nits like this?  Beltzner?
Assignee: nobody → jwalden+bmo
Status: NEW → ASSIGNED

        Attachment #232631 -
        Flags: ui-review?(beltzner)

    
    

    
  

      
      
      
      

        Attached image
          
        New spacing screenshot
        — 
      

    


  

    
    

    
  
beltzner, mconnor, Mano: can we get this reviewed and checked in soon so we can get this in on branch?

    
    

    
  
Comment on attachment 232631 [details] [diff] [review]
Use thin separators

looks good to me, but ping beltzner for ui-review.

        Attachment #232631 -
        Flags: review+

    
  
OS: Linux → All
Hardware: PC → All

    
    

    
  
beltzner, pretty pretty please can you ui-review this so we can get it approved and landed today?

        Attachment #232631 -
        Flags: ui-review?(beltzner) → ui-review+

    
    

    
  
A 30 month old patch waiting for ui-review??

    
    

    
  
It has ui-review+, it just needs checking in (Jeff?). The first hunk already landed as part of the patch for bug 384956.
Keywords: checkin-needed

    
    

    
  
... and the second separator doesn't exist anymore.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → WORKSFORME

    
    

    
  
Huh, I guess I was looking at the wrong file when I checked. There are some other non-thin separators, but I don't know if they're actually a problem:

http://mxr.mozilla.org/mozilla-central/search?string=+<separator&find=preferences

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: