343916 - hidden submit button should have display: none

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Rob Siklos [:robzilla]]

In the whining page, there is a hidden submit button with:
   style="visibility: hidden"

The fact that it is hidden means that it still takes up real estate, which is probably not what we want.

We should have instead:
   style="display: none;"

Comment 1

[Rob Siklos [:robzilla]]

Attachment: patch v1

Comment 2

[Max Kanat-Alexander]

Comment on attachment 228476 [details] [diff] [review]
patch v1

bkor is listed as a template reviewer, on http://www.bugzilla.org/docs/reviewer-list.html

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 228476 [details] [diff] [review]
patch v1

> [%# This hidden submit button must be here to set default behavior when
>     the user presses return on a form input field #%]
> <input type="submit" value="Update / Commit" name="commit"
>-       style="visibility: hidden">
>+       style="display: none;">

Rob, have you read the comment above your change. The comment suggests that visibility:hidden is needed to make this 'work' in at least one UA we care about.  Care to test?

Comment 4

[Rob Siklos [:robzilla]]

(In reply to comment #3)

> 
> Rob, have you read the comment above your change. The comment suggests that
> visibility:hidden is needed to make this 'work' in at least one UA we care
> about.  Care to test?
> 

Ya, I saw the comment, and this change doesn't seem to make a difference.  As far as the form is concerned, it doesn't matter if the element is displayed or not.

Comment 5

[Olav Vitters]

Comment on attachment 228476 [details] [diff] [review]
patch v1

Tested and works with Firefox 1.5.0.4, Konqueror 3.5.3.

Do not have access to Internet Explorer. Requesting review from glob for that.

Note: patch has DOS lineendings. I had to use dos2unix on the patch otherwise it wouldn't apply.

Comment 6

[Justin Wood (:Callek)]

Olav, if all you want for full r+ is an affirmation this works in IE, I am willing to test if you e-mail me a url to a test-instance (and exact steps to test that you want me to try, so that I don't miss something you want to be sure of).  Incase it is faster that way anyway.

Comment 7

[:glob ✱]

Comment on attachment 228476 [details] [diff] [review]
patch v1

r=glob

Comment 8

[:glob ✱]

Comment on attachment 228476 [details] [diff] [review]
patch v1

r=glob

note to self:  drink coffee, then review.

Comment 9

[Frédéric Buclin]

Checking in template/en/default/whine/schedule.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/schedule.html.tmpl,v  <--  schedule.html.tmpl
new revision: 1.6; previous revision: 1.5
done