Clicking on "Get More Extensions" from Thunderbird takes you to Firefox addons page

RESOLVED WORKSFORME

Status

RESOLVED WORKSFORME
12 years ago
10 years ago

People

(Reporter: marcia, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If I click the Extensions link in the Tbird 1.5.0.5 candidate, it takes me to the Firefox addons page instead of the Tbird addons page. I am running today's Bon Echo build.

I know this used to work, not sure what happened.
Created attachment 228502 [details] [diff] [review]
The query string coming from the EM isn't decoded properly -- adding urldecode() call.

Adding fix for $_app var, when assigned from $_GET.
Attachment #228502 - Flags: first-review?(clouserw)
Status: NEW → ASSIGNED
When you're in Tb 1.5.0.4/1.5.0.5 on an Intel Mac, the "Get More Extensions" link takes me to:
https://addons.mozilla.org/extensions.php?app=%257B3550f703-e582-4d05-9a08-453d09bdfdc6%257D

This appears to have the GUID urlencoded twice (%25 => %, %7B => { and %7D => }) -- and we've seen that in Linux and Windows the links work and point to a link w/ the GUID param encoded only once.

So, the patch basically decodes things twice -- but we feel that the proper fix might be in the EM, where we should probably prevent the double-encoding from happening in the first place. 
Comment on attachment 228502 [details] [diff] [review]
The query string coming from the EM isn't decoded properly -- adding urldecode() call.

Comment #2 pretty much covers it.  This appears to only occur in the mac version of thunderbird and that's probably where the fix needs to happen.
Attachment #228502 - Flags: first-review?(clouserw) → first-review-

Comment 4

12 years ago
I can't figure out where the Mac is getting the app id escaped twice vs. windows and Linux. The code is all XP and shared by both Firefox and Thunderbird.

The APP ID strings are listed for Firefox and Thunderbird here:
http://lxr.mozilla.org/mozilla1.8.0/source/browser/app/nsBrowserApp.cpp#53
http://lxr.mozilla.org/mozilla1.8.0/source/mail/app/nsMailApp.cpp#54

The extension manager, adds the app ID to the URL here:

http://lxr.mozilla.org/mozilla1.8.0/source/toolkit/mozapps/extensions/content/extensions.js#200

I don't see any Mac specific code or even any application specific code. Very strange that it's TB Mac only. I'll keep digging.

Comment 5

12 years ago
Ah but for Thunderbird the URL would be going through the operating system which may be escaping the URL again on the Mac perhaps? In Firefox the URL never leaves the mozilla process so no one else can mangle it.

Comment 6

12 years ago
Here's the URL we give to Internet Config on the Mac. It actually opens up the URL in the default browser. 

https://addons.mozilla.org/extensions/?application={3550f703-e582-4d05-9a08-453d09bdfdc6}

The URL isn't escaped at this point.

Comment 7

12 years ago
So we pass to the OS, which encodes, calls the browser, which encodes the second time?

So can we decode once, check for a match, and if no match try decoding a second time?


Comment 8

12 years ago
if Safari is my default browser, it ends up double encoding the URL too, taking us to the wrong page. I wouldn't have expected that to happen. Maybe our Internet Config code is wrong...
(Reporter)

Comment 9

12 years ago
We should really fix this before we ship Thunderbird 2. It is really annoying.
It sounds like this isn't an AMO-side bug, from Scott's most recent comments.  I'm going to reassign it over the tbird-land, though another option would be to use the same URL-redirect model as we're using for Firefox 2 -- it happens to not have the GUID in the URL, so you'd at least work around that problem.
Assignee: morgamic → mscott
Status: ASSIGNED → NEW
Component: Public Pages → General
Flags: first-review-
Product: addons.mozilla.org → Thunderbird
QA Contact: web-ui → general

Updated

10 years ago
Assignee: mscott → nobody
I think this bug can be marked WFM. on Mac Shredder, when I click on "Browse All Add-ons", I get taken to the Thunderbird AMO page, which is correct behaviour.

Thoughts?

Comment 12

10 years ago
I can't comment about this bug from Mac perspective.

But do you see the following? ...
with trunk build in get addons type "notes" in search and get "all results are already installed or incompatible", which is not well worded, because there are additional results in the bottom left "See all results"
(In reply to comment #12)
> But do you see the following? ...
> with trunk build in get addons type "notes" in search and get "all results are
> already installed or incompatible", which is not well worded, because there are
> additional results in the bottom left "See all results"

Yes, but that would be a different bug by itself...

Resolving WFM based on comment #11.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.