XSL code in layout needs updating/sanity check

VERIFIED FIXED in M16

Status

()

Core
Layout
P3
normal
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Peter Van der Beken, Assigned: Nisheeth Ranjan)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
I'm trying to compile/run mozilla with XSL defined. These are the issues i 
currently see (with a build from yesterday).

1) mozilla/layout/xml/document/src/nsXMLContentSink.cpp needs updating.
At line 1144 of this file, following statement doesn't compile.
rv = NS_OpenURI(sl, nsnull, aUrl);

I think it should be 
rv = NS_OpenURI(sl, nsnull, aUrl, nsnull);

that is, if nsnull is allowed for the loadgroup.

2) Loading a XML document with a processing instruction to call a XSL stylesheet 
asserts twice and then hangs the computer.
I tried loading the test in the XSL directory of layout (mozilla/layout/xsl/
tests/book.xml). I get two assertions, when i run past both of them the computer 
hangs. I have no idea what's causing this.
The assertions are:

###!!! ASSERTION: Error: Parser's IStreamListener API was not setup
correctly in constructor.: '(eNone==mParserContext->mStreamListenerState)',
file nsParser.cpp, line 1376

Assertion failure: eXMLContentSinkState_InEpilog != mState, at
nsXMLContentSink.cpp:684

I haven't yet tried loading the test document with a build that doesn't have XSL 
defined. I'll try to do that later on.
This is currently blocking my work on the integration of transformiix (XSLT 
processor) into mozilla.

Comment 1

18 years ago
Reassigning to Nisheeth
Assignee: troy → nisheeth
(Assignee)

Comment 2

18 years ago
Accepting bug...
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → M16
(Assignee)

Comment 3

18 years ago
Moving bugs out by one milestone...
Target Milestone: M16 → M17
(Reporter)

Comment 4

18 years ago
Compiling mozilla without XSL defined and then loading mozilla/layout/xsl/
tests/book.xml loads the XML page and gives:

failed to set the page title.
Document file:///p/xsl/book.xml loaded successfully
Document: Done (0.512 secs)
•••WARNING: not calling OnDataAvailable, file nsAsyncStreamListener.cpp, line 
409
WARNING: not calling OnDataAvailable, file nsAsyncStreamListener.cpp, line 409

I don't think this helps you. :-( We'd really like to get transformiix into the 
build by M16, is there anything i can do to help solve this? I went over the 
ifdef'ed code, but i can't see any obvious problems.
(Assignee)

Comment 5

18 years ago
I just tried building on windows with MOZ_XSL set in my environment (which 
automatically defines XSL for the compiler) and everything in mozilla/layout 
built fine.  

I am in the process of getting extensions/transformiix to build on windows as 
part of the mozilla build.  I don't have much time to devote to XSL, so, if I 
get into things that need sleuthing over an extended period of time, can I bug 
you about them, Peter?

Once we have transformiix building within mozilla, we should debug the XSL hooks 
inside mozilla.  
Target Milestone: M17 → M16
(Assignee)

Comment 6

18 years ago
Tom, a quick question for you.  What is the status of the DOM glue code that 
interfaces between Mozilla and Transformiix?
(Assignee)

Comment 7

18 years ago
This particular bug is no longer occurring.  The XSL code in layout 
compiles fine.  Marking fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 8

18 years ago
Marking veified fixed per last comments.
Status: RESOLVED → VERIFIED

Updated

13 years ago
OS: All
Hardware: Macintosh → All
You need to log in before you can comment on or make changes to this bug.