Make widget not export platform-specific headers to all

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: hwaara, Assigned: hwaara)

Tracking

Trunk
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
widget/ exports a bunch of nsIDragSession headers that are platform-specific, to all platforms.  Each platform should only get its header.
(Assignee)

Comment 1

12 years ago
Created attachment 228668 [details] [diff] [review]
Proposed patch

This patch makes the right platform-specific header exported, depending on the target platform.

The only thing I'm worried about, is whether adding (with +=) to an array after the $(NULL) mark will break any platform?
Attachment #228668 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #228668 - Flags: review? → review?(benjamin)
(Assignee)

Comment 2

12 years ago
Comment on attachment 228668 [details] [diff] [review]
Proposed patch

Trying mento, as I heard bsmedberg is busy moving.
Attachment #228668 - Flags: review?(benjamin) → review?(mark)

Comment 3

12 years ago
Comment on attachment 228668 [details] [diff] [review]
Proposed patch

> The only thing I'm worried about, is whether adding (with +=) to an array after
> the $(NULL) mark will break any platform?

Nope, that's fine.

>+ifneq (,$(filter mac cocoa, $(MOZ_WIDGET_TOOLKIT)))
Get rid of this space: ______^
Attachment #228668 - Flags: review?(mark) → review+
(Assignee)

Updated

12 years ago
Assignee: general → hwaara
(Assignee)

Comment 4

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.