Closed Bug 344132 Opened 14 years ago Closed 14 years ago
No user feedback when adding new search engine fails to load from nonexistent host
A bit more investigation reveals that my test file had an error. Please disregard one assertion from each of the new-profile tests. That is, the only case that produces any assertions is a new profile and a bad host: it sends one assertion as listed above, and does not show any error dialog.
Ah, yeah I noticed this bug when working on the update system. We just need to check isSuccessCode(aStatus) before trying to get aRequest.requestSucceeded. I was planning to roll that into the patch for bug 327932.
(In reply to comment #2) > We just need to check isSuccessCode(aStatus) before trying to get > aRequest.requestSucceeded. So why does the problem only show up for some profiles, in particular (in limited testing) empty ones?
(In reply to comment #3) > So why does the problem only show up for some profiles, in particular (in > limited testing) empty ones? Hrm, I don't know why it wouldn't happen in your old profile. I can reproduce it consistently, with both old and new profiles.
(In reply to comment #4) > Hrm, I don't know why it wouldn't happen in your old profile. Further testing gave no more clues to that mystery. But "this works when I don't think it should" is a pretty benign bug, so as long as the incorrect case is fixed I'm not going to worry about it much.
Depends on: search-update
This should be fixed now that the search engine update patch (bug 327932) has landed on the trunk. Pam, can you verify?
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee: nobody → gavin.sharp
Yes, it's fixed.
You need to log in before you can comment on or make changes to this bug.