344172 - Spellchecker doesn't display suggestion list for misspelled words and doesn't underline them if Russian, Ukrainian or Bulgarian Spell dictionary is installed

Status: VERIFIED FIXED

(Core :: Spelling checker, defect)

Description

[Alexander L. Slovesnik]

1. Install latest Firefox Branch Build 
2. Install Russian Spell Checker from
http://downloads.mozdev.org/dictionaries/spell-ru.xpi (you need to unpack it and put "ru.aff" and "ru.dic" files in "C:\Program Files\Mozilla Firefox\dictionaries" )
3. Select Russian dictionary from context menu.
4. Write misspelled word in Russian in some web form.

Actual results:
Firefox doesn't display suggestion list for misspelled word and doesn't underline it with red line.

Expected results:
Firefox should display suggestion list for misspelled word and underline it with red line.

Additional information:
I've made some tests and found regression window.

This bug doesn't exist in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060705 BonEcho/2.0a3 ID:2006070504
This bug exist in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060706 BonEcho/2.0a3 ID:2006070603
Looking at regression window it's regression from Bug 343532 or Bug 339066

I'll attach some screenshots.

Comment 1

[Alexander L. Slovesnik]

Attachment: Working spell check

Spell check in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060705 BonEcho/2.0a3 ID:2006070504

Comment 2

[Alexander L. Slovesnik]

Attachment: Broken spell check

Spell check in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060706 BonEcho/2.0a3 ID:2006070603

Comment 3

[Alexander L. Slovesnik]

I've made few more tests, looks like Ukrainian and Bulgarian spellchecker are broken too (these are languages with cyrillic alphabet).
Setting severity to major, adding "regression" keyword and asking for blocking 1.8.1.
Will attach 2 more screenshots.

Comment 4

[Alexander L. Slovesnik]

Attachment: Working uk-UA spell check (20060705 build)

Comment 5

[Alexander L. Slovesnik]

Attachment: Broken uk-UA spell check (20060706 build)

Comment 6

[Alexander L. Slovesnik]

Boris, you've helped a lot with Bug 307052. Symptoms of this bug is similar, and I greatly appreciate if you can take a look at it.

Comment 7

[Peter Kasting]

The bugs listed in comment 0 were both fixed by commits Roc made, so he might have some idea where to go with this (I see he's already CCed on the bug).

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's probably a regression from my changes. Please don't bother Boris with it.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Fairly obvious bug in retrospect. Comparing just the bottom 8 bits to see if it's a digit isn't a good idea... we need a better Unicode-aware test here though.

Comment 10

[Scott MacGregor]

Comment on attachment 229985 [details] [diff] [review]
fix

thanks roc!

Comment 11

[Alexander L. Slovesnik]

Is this patch ready to be checked in to trunk? It has needed r/sr.

Comment 12

[Martijn Wargers (dead)]

Checking in mozInlineSpellWordUtil.cpp;
/cvsroot/mozilla/extensions/spellcheck/src/mozInlineSpellWordUtil.cpp,v  <--  mo
zInlineSpellWordUtil.cpp
new revision: 1.6; previous revision: 1.5
done

Checked into trunk.

Comment 13

[Alexander L. Slovesnik]

Verified fixed with "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060724 Minefield/3.0a1" build.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ready to ask for branch approval?

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 229985 [details] [diff] [review]
fix

yes

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 229985 [details] [diff] [review]
fix

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and mark fixed1.8.1 once you have done so.

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I won't be able to check this in for a few days...

Comment 18

[Martijn Wargers (dead)]

Checking in mozInlineSpellWordUtil.cpp;
/cvsroot/mozilla/extensions/spellcheck/src/mozInlineSpellWordUtil.cpp,v  <--  mo
zInlineSpellWordUtil.cpp
new revision: 1.4.2.3; previous revision: 1.4.2.2
done

Checked into 1.8.1 branch.

Comment 19

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 and the STR from comment #0 - spellcheck is working now for the 3 languages (Russian, Ukraine, Bulgarian)