Closed Bug 344187 Opened 14 years ago Closed 14 years ago

restartMessageNoUnlocker misleading on Mac

Categories

(Firefox :: General, defect)

2.0 Branch
PowerPC
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mark, Assigned: mark)

Details

(Keywords: fixed1.8.1, late-l10n, Whiteboard: [has l10n impact])

Attachments

(1 file)

If you attempt to launch a fox while a process is already running, you get this message:

%S is already running, but is not responding. To open a new window, you must first close the existing %S process, or restart your system.

This is restartMessageNoUnlocker.  It's misleading on the Mac, because we don't have any of the remote command line stuff that winfox and linfox have.  The "but is not responding" part of that message is entirely erronous, as are the instructions that follow.

We should come up with a better string to use on the Mac.
Flags: blocking-firefox2?
Attached patch PatchSplinter Review
nsIProfileUnlocker isn't implemented, so neither restartMessageUnlocker nor restartMessageUnlockerMac ever get any airtime.
Assignee: nobody → mark
Status: NEW → ASSIGNED
Attachment #228764 - Flags: review?(beltzner)
The wording indicates that the already-running copy of Firefox will quit in favor of the newly-opened, is this correct?

If that is the case, it's quite weird behavior, and doesn't match what Camino does.
restartMessageUnlocker[Mac] indicates that's what would happen, because that IS what would happen if nsIProfileUnlocker was implemented.  Since it's not, that message will not be displayed.  restartMessageNoUnlocker[Mac] is the message the user will see.
This only happens when you launch Firefox from the command line, right? I don't think we should really block on it, since it's a pretty rare use case, but I'll take a look at your patch and see if we can sneak it in without Axel hurting us.
Flags: blocking-firefox2?
If you have multiple copies of Firefox (including DP, BE, and MF), this message will be displayed whenever you try to launch anything other than the one that's running.

(Sometimes, the system might try to launch a non-running copy when a URL is clicked in another app.  It SHOULD always pick the running copy, but LaunchServices is broken.)

If you only have one copy of Firefox, you won't see this message unless you try launching twice from the Terminal.
Mike, could you at least take a look at this so we can get this baking on the trunk?  The l10n decision is kind of moot until then anyway.
Comment on attachment 228764 [details] [diff] [review]
Patch

As I understand it, the real issue here is that the user would be trying to have two applications access the same profile; I can successfully run two instances of FF, BE, MF or whatever if I point them to different profiles.

The message you're proposing here is, however, less confusing to users than the one that pops up now.

One small change:

restartMessageNoUnlockerMac=A version of %S is already open. Only one version of %S can be open at a time.

(calls out the fact that it could be a different version of the browser; uses Mac-terminology of "open" instead of "running")
Attachment #228764 - Flags: review?(beltzner) → review+
Checked in on the trunk with the proposed message above and s/version/copy/ per beltzner.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 228764 [details] [diff] [review]
Patch

I hope it's not too late for a simple string addition.
Attachment #228764 - Flags: approval1.8.1?
Comment on attachment 228764 [details] [diff] [review]
Patch

a=drivers, please land on 181branch
Attachment #228764 - Flags: approval1.8.1? → approval1.8.1+
Checked in on MOZILLA_1_8_BRANCH before 1.8.1b2.
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.