344199 - nsDOMScriptObjectFactory::GetScriptRuntimeByID should fill in the array for fast lookup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alfred Peng]

The language service should be filled into the array mLanguageArray for future fast lookup by ID.

Comment 1

[Alfred Peng]

Attachment: Patch v1

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 228772 [details] [diff] [review]
Patch v1

The 'if' block in the patch can go - we have already checked the array elt is NULL.  So that block can be reduced to simply:

mLanguageArray[NS_STID_INDEX(aLanguageID)] = lang;

Comment 3

[Alfred Peng]

Attachment: Patch v2

No ASSERTION needed here?

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 228914 [details] [diff] [review]
Patch v2

That looks good to me.  No assertion is necessary, as the array element must be NULL.  Asking bz for sr, as I know he looked in this code at least once :)  Apologies in advance if that isn't appropriate.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 228914 [details] [diff] [review]
Patch v2

Looks good!  sr=bzbarsky

Comment 6

[Leon Sha]

Checking in dom/src/base/nsDOMScriptObjectFactory.cpp;
/cvsroot/mozilla/dom/src/base/nsDOMScriptObjectFactory.cpp,v  <--  nsDOMScriptObjectFactory.cpp
new revision: 1.15; previous revision: 1.14
done