344231 - Clicking an autocomplete entry in the search bar no longer starts the search with the selected entry (Error: aEvent has no properties)

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Ria Klaassen (not reading all bugmail)]

1. In the search box start typing inter.. and choose a suggestion
2. Result: suggestion is copied to the box but it does not go automatically to the search result. 
3. In the JS Console you see the error:

Error: aEvent has no properties
Source File: chrome://browser/content/search/search.xml
Line: 431

Expected behaviour: hitting Enter should not be necessary.
Regression (if this is a regression and not intended behaviour) 
between 1.9a1_2006060912 and 1.9a1_2006060914:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-09+11%3A00&maxdate=2006-06-09+15%3A00

Comment 1

[Ria Klaassen (not reading all bugmail)]

I see the same in branch.

Comment 2

[Pam Greene]

If I understand this report correctly, then I don't see the problem in
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060710 BonEcho/2.0b1.

I type "inter" in the search box, use down-arrow to highlight one of the suggestions, and press return to choose it.  I'm taken directly to a search result page without needing to press return again.  Ria, is that not what you're seeing, or not what you're expecting?

Comment 3

[Ria Klaassen (not reading all bugmail)]

The bug does not occur with the keyboard. Once you've used the keyboard to select, you need to restart the browser first to reproduce the bug (only with the mouse).

Comment 4

[Pam Greene]

Attachment: Fixes issue

* Null-check aEvent in handleSearchCommand, since mouse-initiated searches pass null events.
* Clear the enter event after any search, so leftover non-null events from previous keyboard-initiated searches aren't used for mouse searches.

Holding down the alt key while choosing an autocomplete entry with the mouse won't have any effect on whether the search opens in a new tab.  That's perhaps unfortunate, but it matches what the URL bar does.

Comment 5

[Mike Connor [:mconnor]]

The search bar should match the URL bar behaviour wrt clicks/arrows/etc

Comment 6

[Pam Greene]

I agree; that's what this patch does.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 228839 [details] [diff] [review]
Fixes issue

sr=[e-mail]

Comment 8

[:Gavin Sharp [email: [e-mail]]]

*** Bug 345233 has been marked as a duplicate of this bug. ***

Comment 9

[Pam Greene]

Landed on trunk for baking.

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 228839 [details] [diff] [review]
Fixes issue

a=mconnor on behalf of drivers for checkin to the 1.8 branch

Comment 11

[Pam Greene]

Landed on branch.