Closed
Bug 344369
Opened 19 years ago
Closed 18 years ago
redesign label to specify control element directly
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
1.25 KB,
patch
|
enndeakin
:
first-review+
neil
:
second-review+
|
Details | Diff | Splinter Review |
Now label uses @control attribute or query nsIDOMXULLabeledControlElement from parent element to determine control element. xforms:label (in xhtml content) underlines accesskey if xforms:label direct child of some control. We need add accesskey underlying for xforms controls in xul context. Here we cannot use @control attribute for these proposes and I guess xforms controls shouldn't implement nsIDOMXULLabeledControlElement.
If xul label will provide a way to specify control element directly then xforms label can be able to use it.
Assignee | ||
Updated•18 years ago
|
Assignee: jag → surkov.alexander
Component: XP Toolkit/Widgets → XUL Widgets
Product: Core → Toolkit
Assignee | ||
Comment 1•18 years ago
|
||
Actually there is the way is to override 'labeledControlElement' property. All I need is xul:label's click handler should use this property too.
Attachment #253484 -
Flags: first-review?(enndeakin)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•18 years ago
|
Attachment #253484 -
Flags: second-review?(neil)
Comment 2•18 years ago
|
||
Comment on attachment 253484 [details] [diff] [review]
patch
looks ok. generally, a second review isn't needed for simple patches like this
Attachment #253484 -
Flags: first-review?(enndeakin) → first-review+
Updated•18 years ago
|
Attachment #253484 -
Flags: second-review?(neil) → second-review+
Assignee | ||
Comment 3•18 years ago
|
||
Is there a chance to get this patch on 1.8 branch? Who can approve this?
Comment 4•18 years ago
|
||
(In reply to comment #3)
>Who can approve this?
1.8 branch drivers, of course, via the approval1.8.1.3 flag.
Assignee | ||
Updated•18 years ago
|
Attachment #253484 -
Flags: approval1.8.1.3?
Comment 5•18 years ago
|
||
I doubt it will get approved though, since it is just cleanup that doesn't change any behaviour. Why do you need this in 1.8 when you can just use a workaround?
Assignee | ||
Comment 6•18 years ago
|
||
(In reply to comment #5)
> I doubt it will get approved though, since it is just cleanup that doesn't
> change any behaviour. Why do you need this in 1.8 when you can just use a
> workaround?
>
>
I like to force xforms:label to use xul:label much more (I assume I will extend xforms label binding from xul:label binding and override 'labeledControlElement' property. So I need this for XForms since they should work on 1.8 and on trunk. What kind of workaround do you see?
Comment 7•18 years ago
|
||
Checked in to trunk
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•18 years ago
|
||
Comment on attachment 253484 [details] [diff] [review]
patch
Clearing approval request since xforms took another approach.
Attachment #253484 -
Flags: approval1.8.1.3?
You need to log in
before you can comment on or make changes to this bug.
Description
•