344387 - item labels of select don't focus select on click

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

psyched_weels wrote in bug 332081:

when I press the labels for
the checkboxes inside an select element nothing happens.
I would expect that while pressing/clicking a label the checkbox (or radio in
case of select1) would be set to selected=true.
This is however not defined in the w3c recomendation. It's just a nice feature
of the old label elements in html.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 2

[psyched_weels]

I guess that we need html:label elements for that. (Or at least their way of working). Labels are now implemented as html:span elements. We need something like an @for="id_of_input_element". But we don't necessarily have the name or id of the element. We could generate an id, right?

Or am I wrong in my conclusions?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> I guess that we need html:label elements for that. (Or at least their way of
> working). Labels are now implemented as html:span elements. We need something
> like an @for="id_of_input_element". But we don't necessarily have the name or
> id of the element. We could generate an id, right?
> 
> Or am I wrong in my conclusions?
> 

Note, I guess we have the same problem for xul too :)

It's good to reuse code but I don't prefer generating id. The first I don't see way how it can be done technically. The second we can broke document where xforms are hosted.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 237313 [details] [diff] [review]
patch


>+xul|*:root select[appearance="full"] xul|*.checkbox-label-box,
>+xul|*:root select1[appearance="full"] xul|*.radio-label-box {
>+  display: none;
>+}
>+

Why this?
That part explained, r=me

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 237313 [details] [diff] [review]
patch

(In reply to comment #5)
> (From update of attachment 237313 [details] [diff] [review] [edit])
> 
> >+xul|*:root select[appearance="full"] xul|*.checkbox-label-box,
> >+xul|*:root select1[appearance="full"] xul|*.radio-label-box {
> >+  display: none;
> >+}
> >+
> 
> Why this?
> That part explained, r=me
> 

That hides containers where are placed xul:label and xul:image for checkbox and radiobox. Even if is empty the it is still has border when element is focused. I can't use the containers to show the xforms label since it doesn't allow explicit children.

Comment 7

[aaronr]

well, I'll check it in, but surkov, please open a new bug for the wrong behaviors that your testcase exhibits with this fix:

1) clicking on the label of a select1 radio button should NOT toggle the selection.  If you click on the label of a radio button, this radio button should become the current selection.  But clicking on the same label again should have no affect (since it is already the current selection).  It should not deselect the radio button

2) If you reload the testcase so that nothing is selected and then click both checkboxes, then the bound value should be "l b".  So no radio button should be selected, but there is one that is selected.

Thanks.

Comment 8

[aaronr]

checked into trunk for surkov

Comment 9

[alexander :surkov (:asurkov)]

I filed bug 353598 for aaron's issues.

Comment 10

[aaronr]

checked into 1.8.0 branch on 2006/09/21

Comment 11

[aaronr]

checked into 1.8 branch on 2006/11/21