Closed Bug 344397 Opened 18 years ago Closed 18 years ago

add DOM id to page setup to better support skinning / theming

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86
Windows 98
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mcdavis941.bugs, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

The "Page Setup" dialog is represented internally as "dialog" DOM element.  The "dialog" DOM node has neither an id nor a windowtype, making it hard to write CSS selectors which specifically match this window.  To fix this bug, add an id to the DOM element such as "pageSetup".

current DOM structure

dialog
  vbox.box-inherit.dialog-content-box
    ...
  hbox.dialog-button-box
    ...

proposed DOM structure

dialog#pageSetup
  vbox.box-inherit.dialog-content-box
    ...
  hbox.dialog-button-box
    ...



Reproducible: Always
This was fixed on trunk by bug 345749. If you need it on branches, make the
request on that bug.

-> FIXED (by bug 345749)
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Depends on: 345749
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.