Change updater's name to not be lowercase, and be less generic

VERIFIED FIXED

Status

()

Toolkit
Application Update
--
minor
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: Matthew (lilmatt) Willis, Assigned: Matthew (lilmatt) Willis)

Tracking

({fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
When applying an update (ex: .mar), the updater application runs. On Mac OS X, it appears in the dock and in the application menu as "updater". 

We should at least fix the capitalization, and preferably make it something more recognizable as a legitimate process doing something the user wants.
(Assignee)

Comment 1

12 years ago
Created attachment 229405 [details] [diff] [review]
rev0 - changes names

Changes display name to be "Mozilla Updater".
I didn't use MOZ_APP_NAME or an equivalent since things like "XULRunner Updater" could be confusing to an end user.

While "Mozilla" may be less familiar than say, "Firefox", it is far better than "updater" from a "what the crap is this scary thing running on my system for?!" Keep in mind that while this app is running, the updater.ini text is also displayed, which includes the app name.
Attachment #229405 - Flags: ui-review?
(Assignee)

Updated

12 years ago
Attachment #229405 - Flags: ui-review? → ui-review?(beltzner)
(Assignee)

Comment 2

12 years ago
Since Bugzilla can't handle UTF-16, here's the ASCII version

/* Localized versions of Info.plist keys */

CFBundleName = "Mozilla Updater";
NSHumanReadableCopyright = "Copyright © 2005-2006 Mozilla Foundation";
Comment on attachment 229405 [details] [diff] [review]
rev0 - changes names

Even better might be "Mozilla Software Updater" since it's used to ... uhh ... update mozilla software.
Attachment #229405 - Flags: ui-review?(beltzner) → ui-review+
(Assignee)

Updated

12 years ago
Attachment #229405 - Flags: review?(mconnor)
(Assignee)

Comment 4

12 years ago
Created attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

After chatting with mconnor, using MOZ_APP_DISPLAYNAME looks like the way to go instead. It gets us around messy trademark issues, and allows us to actually READ the file.
Attachment #229405 - Attachment is obsolete: true
Attachment #230535 - Flags: ui-review+
Attachment #230535 - Flags: review?
Attachment #229405 - Flags: review?(mconnor)
(Assignee)

Updated

12 years ago
Attachment #230535 - Flags: review? → review?(mconnor)
(In reply to comment #2)
> NSHumanReadableCopyright = "Copyright © 2005-2006 Mozilla Foundation";

Foundation or Corporation?
(In reply to comment #5)
> Foundation or Corporation?

All IP belongs to the Foundation. All hail the Foundation!

Yeah, this looks good and better than what we have now.
(Assignee)

Comment 7

12 years ago
Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

Moving review over to bsmedberg per mconnor in irc
Attachment #230535 - Flags: review?(mconnor) → review?(benjamin)

Comment 8

12 years ago
Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

This isn't going to work with XULRunner, but we can punt on that for now.
Attachment #230535 - Flags: review?(benjamin) → review+
(Assignee)

Comment 9

12 years ago
Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

Patch checked in on trunk.
Baking.
(Assignee)

Comment 10

12 years ago
Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

Looks happy on trunk. Requesting a181
Attachment #230535 - Flags: approval1.8.1?
Marking as FIXED, as the patch is on Trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

a=beltzner on behalf of drivers for the mozilla_1_8_branch
Attachment #230535 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 13

12 years ago
Patch landed on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
(Assignee)

Comment 14

12 years ago
Verified in update to BonEcho this morning...

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1

-> VERIFIED
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.