344418 - preferencesCmdUnix.label lacks 3 dots

Status: RESOLVED INVALID

(Firefox :: Menus, defect)

Description

[User2351]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060708 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060708 Firefox/2.0b1

"Preferences" should be "Preferences..." because a window is opened.

Reproducible: Always

Actual Results:  
Preferences


Expected Results:  
Preferences...

Comment 1

[Steve England [:stevee]]

Reporter, do you still see this problem with the latest Firefox 2? If not, can you please close this bug as WORKSFORME. Thanks!

Comment 2

[User2351]

Yes, I still see it.

I have updated the URL.

Currently the source is:
<!ENTITY preferencesCmd.label       "Options...">
<!ENTITY preferencesCmdUnix.label       "Preferences">

It should be changed to:
<!ENTITY preferencesCmd.label       "Options...">
<!ENTITY preferencesCmdUnix.label       "Preferences...">

That is: 3 dots should be added.

This bug has zero priority for 2.0 Branch. I therefore changed the version to trunk. The URL given by me also point to trunk source - if not, please correct me.

Comment 3

[Ryan Hickman]

CONFIRMED.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012104 Minefield/3.0b3pre

Comment 4

[Vlado Valastiak [:wladow]]

Attachment: add ellipsis to preferencesCmdUnix.label

This adds ellipsis to preferencesCmdUnix.label. Does this need entity name change?

Comment 5

[User2351]

While I personally want the ellipsis (and have them thanks to my own extension), I noted a week ago, this comment:

https://bugzilla.mozilla.org/show_bug.cgi?id=412387#c14

which invalidate my argument for having them. Following the bug mentioned there, I read another comment:

https://bugzilla.mozilla.org/show_bug.cgi?id=255051#c5

Linking to a GNOME style guide, saying:

"Label the menu item with a trailing ellipsis ("...") only if the command requires further input from the user before it can be performed. Do not add an ellipsis to items that only present a confirmation dialog (such as Delete), or that do not require further input (such as Properties, Preferences or About)."

Since Firefox for Linux is turning into a genuine looking GNOME app these days, I believe the lack of dots may be okay.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 298317 [details] [diff] [review]
add ellipsis to preferencesCmdUnix.label

So, yeah, this needs careful ui-r. You should also rev the entity name.

Comment 7

[Vlado Valastiak [:wladow]]

Attachment: v2

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 298963 [details] [diff] [review]
v2

On GNOME this should stay without an ellipsis.

Comment 9

[Mike Connor [:mconnor]]

GNOME HIG is explicit.  http://developer.gnome.org/projects/gup/hig/1.0/menus.html

So is Windows UIG: http://msdn2.microsoft.com/en-us/library/aa511502.aspx#ellipses

INVALID.