344435 - Let me remove bugs from saved buglists

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Frédéric Buclin]

Bug 313020 lets me add individual bugs to saved searches. I also want to be able to remove them on a per bug basis.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 232820 [details] [diff] [review]
patch, v1

I didn't use this feature yet, so I don't feel confident looking at this particular patch.

Comment 3

[Frédéric Buclin]

Comment on attachment 232820 [details] [diff] [review]
patch, v1

ok, I thought you were based on the work you did for shared queries. :)

Comment 4

[Joel Peshkin]

Comment on attachment 232820 [details] [diff] [review]
patch, v1

Looks good by inspection but I still need to test it.

Comment 5

[Olav Vitters]

Comment on attachment 232820 [details] [diff] [review]
patch, v1

Personally not really a fan of the interface (meaning all of it, removing+adding). Having it on every page seems excessive.

>Index: buglist.cgi
>+
>+            # If we are removing bugs, then we must have an existing
>+            # saved search selected.
>+            if ($action eq 'remove') {
>+                $query_name && ThrowUserError('no_bugs_to_remove');

Do not believe it is actually possible to generate this error with the current UI, but I assume this is just defensive coding?

>+            my $keep_bug = ($action eq 'add') ? 1 : 0;
>+            my $changes = 0;
>+            foreach my $bug_id (split(/[\s,]+/, $cgi->param('bug_ids'))) {
>+                next unless $bug_id;
>+                ValidateBugID($bug_id);
>+                $bug_ids{$bug_id} = $keep_bug;
>+                $changes = 1;
>+            }
>+            ThrowUserError('no_bug_ids') unless $changes;

That will give the error:
  You didn't choose any bugs to add to the saved search.
Even for the 'remove' action.

Other than that it works fine.

Comment 6

[Frédéric Buclin]

Attachment: patch, v2

Comment 7

[Frédéric Buclin]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.344; previous revision: 1.343
done
Checking in template/en/default/global/per-bug-queries.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/per-bug-queries.html.tmpl,v  <--  per-bug-queries.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.184; previous revision: 1.183
done

Comment 8

[Frédéric Buclin]

The documentation has been fixed as part of the docs patch from bug 313020.