Closed Bug 34444 Opened 24 years ago Closed 24 years ago

Crashes while launching 2000-04-04-09-M15/sea Windows commercial build.

Categories

(Core :: Graphics: ImageLib, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: skasinathan, Assigned: dcone)

References

()

Details

(Keywords: smoketest)

Steps: Crashes while trying to launch 2000-04-04-09-M15/sea windows commercial 
build. Command line arguments for mail, composer also crashes.

Stack trace: 

 Call Stack:    (Signature = ConvertRGBToRGB24 b9468bce) 
ConvertRGBToRGB24 
[d:\builds\seamonkey\mozilla\modules\libimg\src\color.cpp, line 510]
il_emit_row 
[d:\builds\seamonkey\mozilla\modules\libimg\src\scale.cpp, line 1184]
ImgDCallbk::ImgDCBHaveRow 
[d:\builds\seamonkey\mozilla\modules\libimg\src\if.cpp, line 148]
gif_clear_screen 
[d:\builds\seamonkey\mozilla\modules\libimg\gifcom\gif.cpp, line 816]
il_gif_write 
[d:\builds\seamonkey\mozilla\modules\libimg\gifcom\gif.cpp, line 1391]
process_buffered_gif_input_data 
[d:\builds\seamonkey\mozilla\modules\libimg\gifcom\gif.cpp, line 675]
gif_delay_time_callback 
[d:\builds\seamonkey\mozilla\modules\libimg\gifcom\gif.cpp, line 728]
timer_callback 
[d:\builds\seamonkey\mozilla\gfx\src\nsImageSystemServices.cpp, line 72]
nsTimer::Fire 
[d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimer.cpp, line 196]
nsTimerManager::FireNextReadyTimer 
[d:\builds\seamonkey\mozilla\widget\timer\src\windows\nsTimerManager.cpp, line 
117]
nsAppShell::Run 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsAppShell.cpp, line 116]
0x02633400
Component: other → ImageLib
Keywords: smoketest
Target Milestone: --- → M15
Looks like it might be imagelib, reassigning to default component owner.

suresh: looks like 34445-7 are duplicates of this bug that need to be 
resolve/dup'd.
Assignee: chofmann → pnunn
QA Contact: leger → elig
*** Bug 34447 has been marked as a duplicate of this bug. ***
*** Bug 34447 has been marked as a duplicate of this bug. ***
When I do a clean install my default homepage is 
http://www.mozilla.org/mozorg.html
Launching mozilla gives me a crash in IMG3250.DLL
To get around the launch crash I edited my prefs.js file and added these lines:
user_pref("browser.startup.homepage","http://www.singleclick.com/~jelwell/speech
.pl");
user_pref("browser.startup.homepage_override.1", false);

(That web page doesn't have any images :)
Almost all pages with images crash.
Quick Update:
Viewer doesn't crash on start up and can display images fine.
Mozilla crashes and chrome looks veryvery bad. 
-P
Status: NEW → ASSIGNED
Quick update#2:
I can duplicate the crash using viewer, if I
look at a page with an animated gif as a background image.
I noticed dcone was working on tiling code, perhaps we 
have a minor glitch in creating the needed buffers when
we redecode the image......
Don:

I'm going to need your help on this one.
I'm trying to track down why the tiled image doesn't have its data
buffer allocated?

I'm reassigning this one to you, but I'll continue to work on it
with you. (That is, if you want me to..)
-P
Assignee: pnunn → dcone
Status: ASSIGNED → NEW
See also 34460, which describes the problem of tiled GIFs not being drawn at all.
The best brkpnt I can find is line 262, gfx/src/nsImageRenderer.cpp,
where img->GetBits is called. If you put a conditional for it to
stop on (aImage->bits == 0) you should catch the process soon before
it crashes.

If you need a simple test page, http://jazz/users/pnunn/publish/aaaa1.html
is doing the job for me.
-P
has anyone called dcone to make sure he's working on this right now? I haven't
seen any comments from him in the bug report and it's the last thing keeping the
tree closed....putting frank whose the sheriff today on the cc list too...
I've been talking to dcone on the phone.
I just backed out nsCSSRendering.cpp changes and this fixes my
local tree. I've checked the change into the tree. Granrose is
ready to respin.

Here's the backout:
cvs update -j3.105 -j3.104 mozilla/layout/html/style/src/nsCSSRendering.cpp

-P
Pam Nunn backed out the nsCSSRendering.cpp change.  Somehow the animated gif 
backgrounds had memory that was not allocated.  
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
2000041206 Win32 commercial build launches without problem, so rubber-stamping as 
verified/fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.