344455 - JSMSG_XML_TAG_NAME_MISMATCH diagnostic needs improvement

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

* It points off by one to the wrong character with the ...^ token pointer.
* It does not tell the name of the start tag, which makes it hard to find the mismatch when looking at non-trivial markup where, e.g., a point tag was closed with > instead of />.

Patch momentarily.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

Comment 2

[Brendan Eich [:brendan]]

The risk of this change is too close to zero to write out in decimal.

The benefit is a diagnostic that helps find the unopened or unclosed tag by name, starting from the error point and going back to the first occurrence of that name. This was helpful in reducing a real-world HTML file into XML and JS, and using E4X to parse the XML.

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 229025 [details] [diff] [review]
fix

Checked into trunk, can bake for a day or two, doesn't need much.

Looking for Firefox beta 2 approval, this is not a blocker, but it's a safe rider.

/be

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 229025 [details] [diff] [review]
fix

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and marked fixed1.8.1 when you have done so.

Comment 5

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-344455.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-344455.js,v  <--  regress-344455.js
initial revision: 1.1

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.1, trunk 20060723 win/linux/mac(ppc|tel)