JSMSG_XML_TAG_NAME_MISMATCH diagnostic needs improvement

VERIFIED FIXED in mozilla1.8.1beta2

Status

()

VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

({verified1.8.1})

Trunk
mozilla1.8.1beta2
verified1.8.1
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
* It points off by one to the wrong character with the ...^ token pointer.
* It does not tell the name of the start tag, which makes it hard to find the mismatch when looking at non-trivial markup where, e.g., a point tag was closed with > instead of />.

Patch momentarily.

/be
(Assignee)

Comment 1

13 years ago
Created attachment 229025 [details] [diff] [review]
fix
Attachment #229025 - Flags: review?(mrbkap)
(Assignee)

Comment 2

13 years ago
The risk of this change is too close to zero to write out in decimal.

The benefit is a diagnostic that helps find the unopened or unclosed tag by name, starting from the error point and going back to the first occurrence of that name. This was helpful in reducing a real-world HTML file into XML and JS, and using E4X to parse the XML.

/be

Status: NEW → ASSIGNED
Attachment #229025 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 3

12 years ago
Comment on attachment 229025 [details] [diff] [review]
fix

Checked into trunk, can bake for a day or two, doesn't need much.

Looking for Firefox beta 2 approval, this is not a blocker, but it's a safe rider.

/be
Attachment #229025 - Flags: approval1.8.1?
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Comment on attachment 229025 [details] [diff] [review]
fix

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and marked fixed1.8.1 when you have done so.
Attachment #229025 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 5

12 years ago
Fixed on the 1.8 branch.

/be
Keywords: fixed1.8.1

Comment 6

12 years ago
Checking in regress-344455.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-344455.js,v  <--  regress-344455.js
initial revision: 1.1
Flags: in-testsuite+

Comment 7

12 years ago
verified fixed 1.8.1, trunk 20060723 win/linux/mac(ppc|tel)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.